!426 [205_4] MuPDF：修复打开颜色选取时器崩溃

Author: xjl12

devel/205_4.md

@@ -0,0 +1,19 @@
+# 205_4
+## 2025/07/16 MuPDF：修复打开颜色选取时器崩溃
+## What
+
+将`qt_glue_widget_rep::render()`使用MuPDF render重实现
+
+## Why
+在启用MuPDF渲染器后，打开菜单栏上的颜色选取器，程序会崩溃
+崩溃原因是`qt_glue_widget_rep::render()`中使用qt_render_rep进行图像加载，与MuPDF冲突
+
+## 如何测试
+配置xmake启用mupdf，并编译：
+```
+xmake f --mupdf=true
+xmake build stem
+xmake run stem
+```
+打开任意测试文档，单击菜单栏上的颜色选取器
+

src/Plugins/MuPDF/mupdf_qt_simple_widget.cpp

@@ -142,24 +142,8 @@ qt_simple_widget_rep::repaint_invalid_regions () {
   canvas ()->surface ()->repaint (qrgn);
 }
 
-static void
-mupdf_pixmap_cleanup_handler (void* info) {
-  fz_pixmap* pix= (fz_pixmap*) info;
-  if (pix) {
-    fz_drop_pixmap (mupdf_context (), pix);
-  }
-}
-
 QImage
 qt_simple_widget_rep::get_backing_store () {
-  fz_pixmap* pix    = ((mupdf_picture_rep*) backing_store->get_handle ())->pix;
-  uchar*     samples= fz_pixmap_samples (mupdf_context (), pix);
-  int        w      = fz_pixmap_width (mupdf_context (), pix);
-  int        h      = fz_pixmap_height (mupdf_context (), pix);
-  fz_keep_pixmap (mupdf_context (), pix);
-  // we keep the samples since QImage will drop it later
-  QImage im=
-      QImage (samples, w, h, 4 * w, QImage::Format_RGBA8888_Premultiplied,
-              mupdf_pixmap_cleanup_handler, pix);
-  return im;
+  fz_pixmap* pix= ((mupdf_picture_rep*) backing_store->get_handle ())->pix;
+  return get_QImage_from_pixmap (pix);
 }

src/Plugins/MuPDF/mupdf_qt_ui_element.cpp

@@ -0,0 +1,53 @@
+/******************************************************************************
+ * MODULE     : mupdf_qt_ui_element.cpp
+ * DESCRIPTION: Modified QT glue widget render process to adapt to MuPDF render
+ * COPYRIGHT  : (C) 2025 The Mogan Stem Authors
+ *******************************************************************************
+ * This software falls under the GNU general public license version 3 or later.
+ * It comes WITHOUT ANY WARRANTY WHATSOEVER. For details, see the file LICENSE
+ * in the root directory or <http://www.gnu.org/licenses/gpl-3.0.html>.
+ ******************************************************************************/
+
+#include "MuPDF/mupdf_renderer.hpp"
+#include "qt_ui_element.hpp"
+
+QTMPixmapOrImage
+qt_glue_widget_rep::render () {
+  if (w > 128 || h > 128) {
+    // Reduce pixmap width and height to improve performance
+    SI factor= max (w, h) / 128;
+    w/= factor;
+    h/= factor;
+  }
+  fz_pixmap* pix= fz_new_pixmap (
+      mupdf_context (), fz_device_rgb (mupdf_context ()), w, h, NULL, 1);
+  mupdf_renderer_rep* ren= the_mupdf_renderer ();
+  ren->begin (pix);
+  rectangle r= rectangle (0, 0, w, h);
+  ren->set_origin (0, 0);
+  ren->encode (r->x1, r->y1);
+  ren->encode (r->x2, r->y2);
+  ren->set_clipping (r->x1, r->y2, r->x2, r->y1);
+  if (col == "") {
+    // do nothing
+  }
+  else {
+    if (is_atomic (col)) {
+      color c= named_color (col->label);
+      ren->set_background (c);
+      ren->set_pencil (c);
+      ren->fill (r->x1, r->y2, r->x2, r->y1);
+    }
+    else {
+      ren->set_shrinking_factor (std_shrinkf);
+      brush old_b= ren->get_background ();
+      ren->set_background (col);
+      ren->clear_pattern (5 * r->x1, 5 * r->y2, 5 * r->x2, 5 * r->y1);
+      ren->set_background (old_b);
+      ren->set_shrinking_factor (1);
+    }
+  }
+  ren->end ();
+
+  return get_QTMPixmapOrImage_from_pixmap (pix);
+}

src/Plugins/MuPDF/mupdf_renderer.cpp

@@ -1316,3 +1316,35 @@ mupdf_renderer_rep::apply_shadow (SI x1, SI y1, SI x2, SI y2) {
   static_cast<mupdf_renderer_rep*> (master)->encode (x2, y2);
   master->put_shadow (this, x1, y1, x2, y2);
 }
+
+static void
+mupdf_pixmap_cleanup_handler (void* info) {
+  fz_pixmap* pix= (fz_pixmap*) info;
+  if (pix) {
+    fz_drop_pixmap (mupdf_context (), pix);
+  }
+}
+
+QImage
+get_QImage_from_pixmap (fz_pixmap* pix) {
+  uchar* samples= fz_pixmap_samples (mupdf_context (), pix);
+  int    w      = fz_pixmap_width (mupdf_context (), pix);
+  int    h      = fz_pixmap_height (mupdf_context (), pix);
+  fz_keep_pixmap (mupdf_context (), pix);
+  // we keep the samples since QImage will drop it later
+  QImage im=
+      QImage (samples, w, h, 4 * w, QImage::Format_RGBA8888_Premultiplied,
+              mupdf_pixmap_cleanup_handler, pix);
+  return im;
+}
+
+QTMPixmapOrImage
+get_QTMPixmapOrImage_from_pixmap (fz_pixmap* pix) {
+  QImage qim= get_QImage_from_pixmap (pix);
+  if (headless_mode) {
+    return QTMPixmapOrImage (qim);
+  }
+  else {
+    return QTMPixmapOrImage (QPixmap::fromImage (qim));
+  }
+}

src/Plugins/MuPDF/mupdf_renderer.hpp

@@ -12,6 +12,7 @@
 #ifndef MUPDF_RENDERER_HPP
 #define MUPDF_RENDERER_HPP
 
+#include "QTMPixmapOrImage.hpp"
 #include "basic_renderer.hpp"
 
 #include <mupdf/fitz.h>
@@ -123,4 +124,8 @@ class mupdf_renderer_rep : public basic_renderer_rep {
 
 mupdf_renderer_rep* the_mupdf_renderer ();
 
+// Convert fz_pixmap to QImage, QTMPixmapOrImage
+QImage           get_QImage_from_pixmap (fz_pixmap* pix);
+QTMPixmapOrImage get_QTMPixmapOrImage_from_pixmap (fz_pixmap* pix);
+
 #endif // defined MUPDF_RENDERER_HPP

src/Plugins/Qt/qt_ui_element.cpp

@@ -85,6 +85,7 @@ class qt_enum_command_rep : public command_rep {
  * glue widget
  ******************************************************************************/
 
+#ifndef USE_MUPDF_RENDERER
 QTMPixmapOrImage
 qt_glue_widget_rep::render () {
   QSize            s= to_qsize (w, h);
@@ -126,6 +127,7 @@ qt_glue_widget_rep::render () {
 
   return pxm;
 }
+#endif
 
 QAction*
 qt_glue_widget_rep::as_qaction () {