Skip to content

Commit 4f4059d

Browse files
ja-nimarlonicus
authored andcommitted
adds parent check to elements shifted within the dom, updates svg cleanup functions
1 parent f0e8246 commit 4f4059d

File tree

1 file changed

+39
-1
lines changed

1 file changed

+39
-1
lines changed

packages/@react-facet/dom-fiber/src/setupHostConfig.ts

+39-1
Original file line numberDiff line numberDiff line change
@@ -1021,6 +1021,10 @@ export const setupHostConfig = (): HostConfig<
10211021
},
10221022

10231023
insertBefore: function (parentInstance, child, beforeChild) {
1024+
if (isElementContainer(child)) {
1025+
parentInstance.children.add(child)
1026+
}
1027+
10241028
parentInstance.element.insertBefore(child.element, beforeChild.element)
10251029
},
10261030

@@ -1033,6 +1037,10 @@ export const setupHostConfig = (): HostConfig<
10331037
},
10341038

10351039
insertInContainerBefore: function (container, child, beforeChild) {
1040+
if (isElementContainer(child)) {
1041+
container.children.add(child)
1042+
}
1043+
10361044
container.element.insertBefore(child.element, beforeChild.element)
10371045
},
10381046

@@ -1101,25 +1109,55 @@ const cleanupElementContainer = (parent: ElementContainer, instance: ElementCont
11011109
instance.children.clear()
11021110

11031111
instance.className?.()
1112+
instance.cx?.()
1113+
instance.cy?.()
1114+
instance.d?.()
11041115
instance['data-droppable']?.()
11051116
instance['data-narrate']?.()
11061117
instance['data-narrate-as']?.()
11071118
instance['data-narrate-after']?.()
11081119
instance['data-narrate-before']?.()
11091120
instance['data-testid']?.()
11101121
instance['data-x-ray']?.()
1122+
instance.fill?.()
11111123
instance.id?.()
11121124
instance.src?.()
1125+
instance.height?.()
11131126
instance.href?.()
11141127
instance.target?.()
11151128
instance.autoPlay?.()
11161129
instance.loop?.()
11171130
instance.disabled?.()
11181131
instance.maxLength?.()
1132+
instance.r?.()
1133+
instance.rx?.()
1134+
instance.ry?.()
11191135
instance.rows?.()
1120-
instance.value?.()
1136+
instance.stroke?.()
1137+
instance.strokeWidth?.()
11211138
instance.type?.()
11221139
instance.text?.()
1140+
instance.value?.()
1141+
instance.x?.()
1142+
instance.x1?.()
1143+
instance.x2?.()
1144+
instance.width?.()
1145+
instance.y?.()
1146+
instance.y1?.()
1147+
instance.y2?.()
1148+
instance.viewBox?.()
1149+
instance.xLinkHref?.()
1150+
instance.fillOpacity?.()
1151+
instance.strokeOpacity?.()
1152+
instance.strokeLinecap?.()
1153+
instance.strokeLinejoin?.()
1154+
instance.points?.()
1155+
instance.offset?.()
1156+
instance.stopColor?.()
1157+
instance.stopOpacity?.()
1158+
instance.fontFamily?.()
1159+
instance.fontSize?.()
1160+
instance.cohinline?.()
11231161
}
11241162

11251163
const noop = () => {}

0 commit comments

Comments
 (0)