Skip to content

Commit 4dd74c4

Browse files
committed
WIP
1 parent 0caf1d9 commit 4dd74c4

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

kafka/resource_kafka_topic_test.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
uuid "github.com/hashicorp/go-uuid"
1111
r "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1212
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
13+
"google.golang.org/protobuf/internal/errors"
1314

1415
"github.com/IBM/sarama"
1516
)
@@ -144,8 +145,10 @@ func TestAcc_TopicAlterReplicationFactor(t *testing.T) {
144145

145146
r.Test(t, r.TestCase{
146147
ProviderFactories: overrideProviderFactory(),
147-
PreCheck: func() { testAccPreCheck(t) },
148-
CheckDestroy: testAccCheckTopicDestroy,
148+
PreCheck: func() {
149+
testAccPreCheck(t)
150+
},
151+
CheckDestroy: testAccCheckTopicDestroy,
149152
Steps: []r.TestStep{
150153
{
151154
Config: cfg(t, bs, fmt.Sprintf(testResourceTopic_updateRF, topicName, 1, 7)),
@@ -251,6 +254,8 @@ func testResourceTopic_produceMessages(messages []*sarama.ProducerMessage) r.Tes
251254
}
252255
kafkaConfig.Producer.Return.Errors = true
253256
kafkaConfig.Producer.Return.Successes = true
257+
kafkaConfig.Metadata.Full = true
258+
254259
kafkaConfig.Producer.RequiredAcks = sarama.WaitForAll
255260
kafkaConfig.Producer.Timeout = 90 * time.Second
256261
kafkaConfig.Producer.Retry.Max = 5
@@ -269,12 +274,14 @@ func testResourceTopic_produceMessages(messages []*sarama.ProducerMessage) r.Tes
269274

270275
// rety 5 times
271276
retries := 5
277+
produceErrs := make([]error, 0, retries)
272278
for i := 0; i < retries; i++ {
273279
if errs := producer.SendMessages(messages); errs != nil {
280+
produceErrs = append(produceErrs, errs)
274281
for _, err := range errs.(sarama.ProducerErrors) {
275282
log.Println("[ERROR] Write to kafka failed: ", err)
276283
if i == retries-1 {
277-
return err
284+
return errors.Wrap(produceErrs[len(produceErrs)-1], "failed to produce messages")
278285
}
279286
}
280287
} else {

0 commit comments

Comments
 (0)