fix: resolve daemon startup race conditions (#45)

Three race conditions were causing the daemon to silently fail during
startup, leaving the battery charging uncontrolled:

- launchd bootout followed immediately by bootstrap returns I/O error
  because launchd hasn't finished cleanup. Added 0.5s delay between
  the two calls and retry-on-failure for bootstrap.
- createSafetyDaemon() kickstarted the safety watchdog before the main
  daemon was running, causing the watchdog to detect a missing daemon
  and attempt a conflicting restart. Removed the kickstart -- the
  watchdog now relies on StartCalendarInterval (:00/:30).
- Maintain sent SIGTERM to the old daemon and immediately proceeded
  with startup. The old daemon's cleanup (re-enable charging, exit)
  could race with the new daemon's bootout. Now waits up to 5s for
  the old process to exit.

Bumps version to 2.1.2.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: MoonBoi9001

Sources/AppleJuice/AppleJuice.swift

@@ -1,7 +1,7 @@
 import ArgumentParser
 import Foundation
 
-let appVersion = "2.1.1"
+let appVersion = "2.1.2"
 
 @main
 struct AppleJuice: ParsableCommand {

Sources/AppleJuice/Commands/Maintain.swift

@@ -100,6 +100,11 @@ struct Maintain: ParsableCommand {
         if let pid {
             if kill(pid, 0) == 0 {
                 kill(pid, SIGTERM)
+                // Wait for old daemon to exit before starting new one
+                for _ in 0..<50 {
+                    if kill(pid, 0) != 0 { break }
+                    Thread.sleep(forTimeInterval: 0.1)
+                }
             }
         }
 

Sources/AppleJuice/Daemon/DaemonManager.swift

@@ -77,17 +77,16 @@ enum DaemonManager {
 
     /// Start the maintain daemon via launchctl bootstrap + kickstart.
     static func startDaemon() {
-        // Bootout any existing instance (silent — service may not be loaded)
         launchctl("launchctl bootout gui/\(uid)/com.apple-juice.app", silent: true)
-        // Ensure the service is enabled. `maintain stop` disables it, and
-        // createDaemon() skips the enable call when the plist hasn't changed.
+        Thread.sleep(forTimeInterval: 0.5)
         launchctl("launchctl enable gui/\(uid)/com.apple-juice.app")
-        // Bootstrap the plist so launchd manages the process
         if FileManager.default.fileExists(atPath: Paths.daemonPath) {
-            launchctl("launchctl bootstrap gui/\(uid) '\(Paths.daemonPath)'")
+            let result = launchctl("launchctl bootstrap gui/\(uid) '\(Paths.daemonPath)'")
+            if !result.succeeded {
+                Thread.sleep(forTimeInterval: 1)
+                launchctl("launchctl bootstrap gui/\(uid) '\(Paths.daemonPath)'")
+            }
         }
-        // RunAtLoad only fires once per login session. After a bootout+bootstrap
-        // cycle, kickstart is needed to actually launch the process.
         launchctl("launchctl kickstart gui/\(uid)/com.apple-juice.app")
     }
 
@@ -166,8 +165,15 @@ enum DaemonManager {
         // the service is loaded in launchd.
         launchctl("launchctl enable gui/\(uid)/com.apple-juice.safety")
         launchctl("launchctl bootout gui/\(uid)/com.apple-juice.safety", silent: true)
-        launchctl("launchctl bootstrap gui/\(uid) '\(path)'")
-        launchctl("launchctl kickstart gui/\(uid)/com.apple-juice.safety")
+        Thread.sleep(forTimeInterval: 0.5)
+        let result = launchctl("launchctl bootstrap gui/\(uid) '\(path)'")
+        if !result.succeeded {
+            Thread.sleep(forTimeInterval: 1)
+            launchctl("launchctl bootstrap gui/\(uid) '\(path)'")
+        }
+        // No kickstart -- let StartCalendarInterval handle timing.
+        // Kickstarting here races with daemon startup since createSafetyDaemon()
+        // is called from createDaemon() just before startDaemon().
     }
 
     /// Remove the safety watchdog plist and unload it. Only called during uninstall.