Skip to content

Commit 11b0f9b

Browse files
committed
feat: make use_inplace_pin_memory configurable via env
1 parent 0eef081 commit 11b0f9b

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

checkpoint_engine/ps.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ def register_checkpoint(
263263
files: list[str] | None = None,
264264
named_tensors: dict[str, torch.Tensor] | None = None,
265265
use_shared_memory_pool: bool = False,
266-
use_inplace_pin_memory: bool = True,
266+
use_inplace_pin_memory: bool | None = None,
267267
) -> None:
268268
"""
269269
Register a checkpoint to the parameter server. Both files and named_tensors will be registered together.
@@ -282,6 +282,12 @@ def register_checkpoint(
282282
use_inplace_pin_memory: If True (default), allows inplace pin memory for /dev/shm/ safetensors files.
283283
This option is ignored when ``use_shared_memory_pool`` is True.
284284
"""
285+
if use_inplace_pin_memory is None:
286+
env_str = os.getenv("PS_USE_INPLACE_PIN_MEMORY", "true")
287+
use_inplace_pin_memory = env_str.lower() in ["true", "1", "yes", "y"]
288+
logger.info(
289+
f"[rank{self._rank}] use_inplace_pin_memory set to {use_inplace_pin_memory} by environment variable PS_USE_INPLACE_PIN_MEMORY={env_str}"
290+
)
285291
if self.device_manager.device_type != "cuda" and use_inplace_pin_memory:
286292
logger.warning(
287293
f"[rank{self._rank}] Only cuda devices support in-place pin memory, set use_inplace_pin_memory to False"

0 commit comments

Comments
 (0)