speed up import of json reports with RcppSimdJson::fload #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JohnPalmer , I have replaced the
jsonlite::fromJSON()with substantially fasterRcppSimdJson::fload()(see https://github.com/eddelbuettel/rcppsimdjson ) to speed up themosquitoR::get_malert_data(). I have not measured, but it feels 2-3 times faster and will get more noticeable with every additional year of data.One caveat, is that the flattening strategy of
RcppSimdJson::fload()is different fromjsonlite::fromJSON(), which results in a slightly different data structure of the output tibble. I don't know if this change would break any of the existing workflows.