Replace UserFactory for user fixture

Author: epou

mosquito_alert/authorization/tests/test_admin.py

@@ -1,7 +1,6 @@
 from django.urls import reverse
 
 from mosquito_alert.geo.tests.factories import BoundaryFactory
-from mosquito_alert.users.tests.factories import UserFactory
 
 from ..models import BoundaryAuthorization, BoundaryMembership
 from .factories import BoundaryAuthorizationFactory
@@ -13,13 +12,12 @@ def test_changelist(self, admin_client):
         response = admin_client.get(url)
         assert response.status_code == 200
 
-    def test_add(self, admin_client, freezer):
+    def test_add(self, admin_client, freezer, user):
         url = reverse("admin:authorization_boundaryauthorization_add")
         response = admin_client.get(url)
         assert response.status_code == 200
 
         boundary = BoundaryFactory()
-        user = UserFactory()
 
         response = admin_client.post(
             url,

mosquito_alert/identifications/tests/test_models.py

@@ -22,7 +22,6 @@
 from mosquito_alert.individuals.tests.factories import IndividualFactory
 from mosquito_alert.taxa.models import Taxon
 from mosquito_alert.taxa.tests.factories import TaxonFactory
-from mosquito_alert.users.tests.factories import UserFactory
 from mosquito_alert.utils.tests.test_models import BaseTestObservableMixin, BaseTestTimeStampedModel
 
 from ..models import (
@@ -1115,9 +1114,8 @@ def test_on_delete_counters_are_updated(self, was_skipped):
         assert photo_task.total_external == 0
 
     # Meta
-    def test_constraint_unique_user_by_task(self):
+    def test_constraint_unique_user_by_task(self, user):
         task = PhotoIdentificationTaskFactory()
-        user = UserFactory()
         with pytest.raises(IntegrityError, match=r"unique constraint"):
             self.factory_cls.create_batch(size=2, user=user, task=task)
 

mosquito_alert/moderation/tests/test_models.py

@@ -7,7 +7,6 @@
 from django.db.utils import IntegrityError
 from django.utils import timezone
 
-from mosquito_alert.users.tests.factories import UserFactory
 from mosquito_alert.utils.tests.test_models import AbstractDjangoModelTestMixin, BaseTestTimeStampedModel
 
 from ..models import Flag, FlagInstance, FlagModeratedModel
@@ -245,14 +244,13 @@ def test_flag_counter_decrease_after_delete(self):
         assert obj.flag.count == 10
 
     # meta
-    def test_constraint_unique_flag_by_user_only_if_user_is_not_null(self):
+    def test_constraint_unique_flag_by_user_only_if_user_is_not_null(self, user):
         flag = FlagFactory()
 
         # Case user is null -> NOT RAISE
         _ = self.factory_cls.create_batch(size=2, flag=flag, user=None)
 
         # Case user is not null -> RAISE
-        user = UserFactory()
         with pytest.raises(IntegrityError, match=r"unique constraint"):
             self.factory_cls.create_batch(size=2, flag=flag, user=user)