Merge pull request #349 from Mosquito-Alert/fix_device_api_fcm_token

Fix fcm_token duplicates

Author: epou

api/serializers.py

@@ -1639,7 +1639,7 @@ def create(self, validated_data):
         # That is for the users that are migrating from the legacy API to this.
         device = Device.objects.filter(
             models.Q(model=model) |
-            models.Q(registration_id=validated_data.get('fcm_token'))
+            models.Q(registration_id=validated_data.get('registration_id'))
         ).filter(user=user, device_id=None).first()
         if device:
             Device.objects.filter(user=user, model=model, device_id=device_id).delete()

api/tests/test_views.py

@@ -10,6 +10,8 @@
 from django.utils import timezone
 from django.utils.module_loading import import_string
 
+from fcm_django.models import DeviceType
+
 from rest_framework import status
 from rest_framework.authtoken.models import Token
 from rest_framework.test import APIClient
@@ -731,6 +733,39 @@ def test_device_without_device_id_is_updated_on_create(self, app_user):
         assert device.pk == device_pk
         assert Device.objects.filter(user=app_user).count() == 1
 
+    def test_device_with_same_fcm_token_is_updated_on_create(self, app_user, app_api_client):
+        device = Device.objects.create(
+            user=app_user,
+            device_id=None,
+            registration_id='fcm_unique_token',
+            type=DeviceType.ANDROID,
+            model=None,
+        )
+        response = app_api_client.post(
+            self.endpoint,
+            data={
+                'device_id': 'unique_id',
+                'fcm_token': 'fcm_unique_token',
+                'type': device.type,
+                'manufacturer': device.manufacturer,
+                'model': 'new_model',
+                'os': {
+                    'name': 'test_os_name',
+                    'version': 'test_os_version'
+                }
+            },
+            format='json'
+        )
+        assert response.status_code == status.HTTP_201_CREATED
+        assert Device.objects.filter(user=app_user).count() == 1
+        device.refresh_from_db()
+        assert device.device_id == 'unique_id'
+        assert device.model == 'new_model'
+        assert device.registration_id == 'fcm_unique_token'
+        assert device.os_name == 'test_os_name'
+        assert device.os_version == 'test_os_version'
+
+
 @pytest.mark.django_db
 @pytest.mark.usefixtures("taxa")
 class TestIdentificationTaskAnnotationsApi: