Added tests

Author: epou

api/serializers.py

@@ -1005,7 +1005,18 @@ def validate(self, data):
                 data["status"] = ExpertReportAnnotation.STATUS_PUBLIC
 
         data['validation_complete_executive'] = data.pop("is_decisive")
-
+        user_role = data['user']
+        if isinstance(user_role, User):
+            user_role = UserStat.objects.filter(user=user_role).first()
+        can_set_is_decisive = False
+        if user_role:
+            can_set_is_decisive = user_role.has_role_permission_by_model(
+                action='mark_as_decisive',
+                model=ExpertReportAnnotation,
+                country=data['report'].country
+            )
+        if not can_set_is_decisive:
+            data['validation_complete_executive'] = False
         return data
 
     def create(self, validated_data):

api/tests/conftest.py

@@ -6,6 +6,7 @@
 
 from rest_framework.authtoken.models import Token
 
+from django.contrib.auth.models import Group
 from django.core.files.uploadedfile import SimpleUploadedFile
 from django.core.management import call_command
 from django.contrib.auth import get_user_model
@@ -18,7 +19,7 @@
 from api.tests.utils import grant_permission_to_user
 from api.tests.clients import AppAPIClient
 
-from tigacrafting.models import IdentificationTask, Taxon
+from tigacrafting.models import IdentificationTask, Taxon, UserStat
 from tigaserver_app.models import EuropeCountry, Report, Photo
 
 from .factories import create_mobile_user, create_regular_user
@@ -250,4 +251,47 @@ def taxon_root():
         rank=Taxon.TaxonomicRank.CLASS,
         name="Insecta",
         common_name=""
-    )
+    )
+
+@pytest.fixture
+def group_expert():
+    group, _ = Group.objects.get_or_create(name="expert")
+    return group
+
+@pytest.fixture
+def group_superexpert():
+    group, _ = Group.objects.get_or_create(name="superexpert")
+    return group
+
+@pytest.fixture
+def user_with_role_annotator(user, group_expert):
+    user.groups.add(group_expert)
+    return user
+
+@pytest.fixture
+def user_with_role_annotator_in_country(user_with_role_annotator, es_country):
+    user_stat = UserStat.objects.get(user=user_with_role_annotator)
+    user_stat.native_of = es_country
+    user_stat.save()
+
+    return user_with_role_annotator
+
+@pytest.fixture
+def user_with_role_supervisor_in_country(user, group_expert, es_country):
+    user.groups.add(group_expert)
+    user_stat = UserStat.objects.get(user=user)
+    user_stat.national_supervisor_of = es_country
+    user_stat.save()
+
+    return user
+
+@pytest.fixture
+def user_with_role_reviewer(user, group_superexpert):
+    user.groups.add(group_superexpert)
+    return user
+
+@pytest.fixture
+def user_with_role_admin(user):
+    user.is_superuser = True
+    user.save()
+    return user

api/tests/integration/identification_tasks/annotations/create.tavern.yml

@@ -230,4 +230,124 @@ stages:
       strict:
         - json:off
       json:
-        id: !int "{assignment.pk}"
+        id: !int "{assignment.pk}"
+
+---
+
+test_name: User can create a new annotation if annotator
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - user_with_role_annotator
+    - jwt_token_user
+    - taxon_root
+  - parametrize:
+      key: is_decisive
+      vals:
+        - true
+        - false
+
+stages:
+  - name: Create classification
+    request:
+      url: "{api_live_url}/{endpoint}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "POST"
+      json:
+        classification:
+          taxon_id: !int "{taxon_root.pk}"
+          confidence_label: 'definitely'
+        is_decisive: "{is_decisive}"
+    response:
+      status_code: 201
+      strict:
+        - json:off
+      json:
+        is_decisive: false
+
+---
+
+test_name: User can create a new annotation if supervisor
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - user_with_role_supervisor_in_country
+    - jwt_token_user
+    - taxon_root
+  - parametrize:
+      key: is_decisive
+      vals:
+        - true
+        - false
+
+stages:
+  - name: Create classification
+    request:
+      url: "{api_live_url}/{endpoint}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "POST"
+      json:
+        classification:
+          taxon_id: !int "{taxon_root.pk}"
+          confidence_label: 'definitely'
+        is_decisive: "{is_decisive}"
+    response:
+      status_code: 201
+      strict:
+        - json:off
+      json:
+        is_decisive: !bool "{is_decisive}"
+
+---
+
+test_name: User can create a new annotation if reviewer
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - user_with_role_reviewer
+    - jwt_token_user
+    - taxon_root
+  - parametrize:
+      key: is_decisive
+      vals:
+        - true
+        - false
+
+stages:
+  - name: Create classification
+    request:
+      url: "{api_live_url}/{endpoint}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "POST"
+      json:
+        classification:
+          taxon_id: !int "{taxon_root.pk}"
+          confidence_label: 'definitely'
+        is_decisive: "{is_decisive}"
+    response:
+      status_code: 201
+      strict:
+        - json:off
+      json:
+        is_decisive: !bool "{is_decisive}"

api/tests/integration/identification_tasks/annotations/delete.tavern.yml

@@ -35,3 +35,81 @@ stages:
       method: "DELETE"
     response:
       status_code: 405
+
+---
+
+test_name: Delete is disabled if annotator
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - annotation
+    - user_with_role_annotator
+    - jwt_token_user
+
+stages:
+  - name: Delete classification
+    request:
+      url: "{api_live_url}/{endpoint}/{annotation.pk}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "DELETE"
+    response:
+      status_code: 403
+
+---
+
+test_name: Delete is disabled if supervisor
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - annotation
+    - user_with_role_supervisor_in_country
+    - jwt_token_user
+
+stages:
+  - name: Delete classification
+    request:
+      url: "{api_live_url}/{endpoint}/{annotation.pk}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "DELETE"
+    response:
+      status_code: 403
+
+---
+
+test_name: Delete is disabled if reviewer
+
+
+includes:
+  - !include schema.yml
+
+marks:
+  - usefixtures:
+    - api_live_url
+    - endpoint
+    - annotation
+    - user_with_role_reviewer
+    - jwt_token_user
+
+stages:
+  - name: Delete classification
+    request:
+      url: "{api_live_url}/{endpoint}/{annotation.pk}/"
+      headers:
+        Authorization: "Bearer {jwt_token_user}"
+      method: "DELETE"
+    response:
+      status_code: 403