'Not sure' should be label as taxon Insecta

Author: epou

tigacrafting/migrations/0026_populate_expertreportannotation_taxon.py

@@ -42,6 +42,12 @@ def set_expertreportannotation_taxon(apps, schema_editor):
         )
     )
 
+    # Case 'Not sure':
+    expert_report_annotation_qs.filter(category_id=9).update(
+        confidence=1.0,
+        taxon_id=1      # This is Taxon.get_root().
+    )
+
     # Otherwise, use category.
     expert_report_annotation_qs.filter(category__isnull=False).update(
         taxon=models.Subquery(

tigacrafting/models.py

@@ -499,9 +499,9 @@ def assign_to_user(self, user: User) -> None:
         )
 
     def get_display_identification_label(self) -> str:
-        if not self.is_done:
+        if not self.is_done or not self.taxon:
             return _("species_unclassified")
-        if not self.taxon:
+        if self.taxon.is_root():
             return _("species_notsure")
 
         return self.taxon.get_display_friendly_common_name()
@@ -1115,11 +1115,13 @@ def get_category_euro(self) -> str:
             return dict([(-3, 'Unclassified')] + list(SITE_CATEGORIES))[self.get_score()]
         elif self.report.type == 'adult':
             if not self.taxon:
-                return "Not sure"
+                return "Unclassified"
             if self.taxon.is_relevant:
                 with translation.override('en'):
                     return "{} {}".format(self.confidence_label, self.taxon.name)
             if self.taxon.is_root():
+                if self.category_id == 9: # Not sure
+                    return "Not sure"
                 return "Other species"
             return "Other species - " + self.taxon.name
 
@@ -1522,6 +1524,9 @@ def get_from_old_classification(cls, category: Optional[Categories] = None, comp
             return other_species.taxa.first()
 
         if category:
+            # Special case for 'Not sure':
+            if category.pk == 9:
+                return cls.get_root()
             return category.taxa.first()
 
         return None

tigaserver_app/models.py

@@ -2355,6 +2355,7 @@ def get_final_combined_expert_category_euro(self) -> str:
         if not identification_task:
             return "Unclassified"
         if not identification_task.taxon:
+            # TODO: At some point this should be rename to Off-topic.
             return "Not sure"
         if identification_task.status == IdentificationTask.Status.CONFLICT:
             return "Conflict"

tigaserver_app/tests/tests.py

@@ -1410,6 +1410,9 @@ def test_annotate_coarse(self):
             category_text = classification['category']
             category_id = int(classification['category_id'])
             value = classification['value']
+            if category.pk == 9:
+                # Not sure is displayed as 'Other species'
+                category = Categories.objects.get(pk=2)
             self.assertEqual(category_text, category.name, "Category should be {0}, is {1}".format(category.name, category_text))
             self.assertEqual(category_id, category.id, "Category id should be {0}, is {1}".format(category.id, category_id))
             if category.specify_certainty_level: