MountainUnicorn
diff --git a/‎CHANGELOG.md‎
Lines changed: 1 addition & 0 deletions b/‎CHANGELOG.md‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎core/knowledge/test-discovery-patterns.json‎
Lines changed: 147 additions & 0 deletions b/‎core/knowledge/test-discovery-patterns.json‎
Lines changed: 147 additions & 0 deletions
diff --git a/‎core/lib/impact-hint.sh‎
Lines changed: 173 additions & 0 deletions b/‎core/lib/impact-hint.sh‎
Lines changed: 173 additions & 0 deletions
diff --git a/‎core/rules/tdd-enforcement.md‎
Lines changed: 57 additions & 0 deletions b/‎core/rules/tdd-enforcement.md‎
Lines changed: 57 additions & 0 deletions
@@ -11,6 +11,7 @@ For commit-level detail see `git log`.
 - **`/add:agents-md` skill** — generates a tool-portable `AGENTS.md` at project root from `.add/` state. Maturity-aware verbosity (POC bullets → Alpha sectioned → Beta full → GA full + team conventions). ADD-managed content wrapped in `<!-- ADD:MANAGED:START … -->` markers so user-authored sections survive regeneration. Modes: `--write` (default), `--check` (CI drift gate, exit 1 on drift), `--merge` / `--import` (absorb hand-curated files). Implemented as `scripts/generate-agents-md.py` plus `core/skills/agents-md/SKILL.md`; fixture tests cover POC/Alpha/Beta render, drift detection, merge flow, idempotency, and staleness-marker clearing. Integrated into `/add:init` (initial generation) and `/add:spec` (active-spec pointer update). Opt-in `agentsMd.gateOnVerify` in `.add/config.json` enables Gate 4.5 in `/add:verify`.
 - **PostToolUse staleness hook for AGENTS.md** — `runtimes/claude/hooks/post-write.sh` now writes `.add/agents-md.stale` when `.add/config.json`, `core/rules/*.md`, or `core/skills/*/SKILL.md` changes and an `AGENTS.md` exists at root. The hook never auto-rewrites AGENTS.md — the human triggers regen.
 - **Prompt-injection defense** (spec `prompt-injection-defense`, M3 Cycle 2) — three-layer GA security story. New auto-loaded rule `core/rules/injection-defense.md` teaches the agent to treat untrusted content (PR comments, web fetches, foreign repos, `node_modules`) as data, never as instructions. New PostToolUse scan hook `runtimes/claude/hooks/posttooluse-scan.sh` pattern-matches tool output (Read, WebFetch, WebSearch, Bash) against `core/security/patterns.json` — eight named patterns covering OWASP Top 10 Agentic 2026, Snyk ToxicSkills, and the January 2026 Comment-and-Control attack. Audit events append to `.add/security/injection-events.jsonl`. New Tier-1 knowledge file `core/knowledge/threat-model.md` documents trust boundaries, defended attacks (T1-T5), out-of-scope threats, and warn-only posture for v0.9. Users can extend without forking via `.add/security/patterns.json` (project) or `~/.claude/add/security/patterns.json` (workstation).
+- **Test-deletion guardrail** ([`specs/test-deletion-guardrail.md`](specs/test-deletion-guardrail.md), M3 Cycle 3). Defends ADD's signature TDD claim against the Kent Beck / TDAD-paper failure mode ("the genie doesn't want to do TDD — it deletes the failing test"). New `scripts/check-test-count.py` snapshot/compare/gate CLI plus `core/lib/impact-hint.sh` files-likely-affected helper. New Gate 3.5 in `/add:verify` fails the cycle if `tests_removed > 0` without a recorded override. Renames (same body, new name) allowed; replacements (same name, rewritten body) require `--allow-test-rewrite` + human approval persisted in `.add/cycles/cycle-{N}/overrides.json`. Justification marker `[ADD-TEST-DELETE: <reason>]` also accepted as commit trailer. New `core/knowledge/test-discovery-patterns.json` catalog covers Python, TS/JS, Go, Ruby, Rust — extensible per project.
 
 ### Changed
 
 
@@ -0,0 +1,147 @@
+{
+  "_meta": {
+    "version": "0.1.0",
+    "added": "v0.9.0",
+    "spec": "specs/test-deletion-guardrail.md",
+    "purpose": "Per-language regex catalog for discovering test functions inside test files. Used by test-surface-snapshot.sh and scripts/check-test-count.py. Users may extend for additional frameworks (bun:test, vitest variants, pytest plugins) by copying this file into their project's knowledge directory and PRing back.",
+    "notes": [
+      "Patterns match the *declaration line* of a test function; the body is then scanned until a dedent/close-brace.",
+      "`function_name_group` indexes the regex capture group that contains the function / describe / it name. 1-based.",
+      "`file_globs` filters files the catalog is considered for — a first-pass optimization.",
+      "Body normalization strips whitespace, line-comments (`#` or `//`), and the function-name token itself before SHA-1 hashing."
+    ]
+  },
+  "languages": {
+    "python": {
+      "file_globs": ["**/test_*.py", "**/*_test.py", "**/tests/**/*.py"],
+      "patterns": [
+        {
+          "regex": "^\\s*def\\s+(test_\\w+)\\s*\\(",
+          "function_name_group": 1,
+          "description": "pytest / unittest function"
+        },
+        {
+          "regex": "^\\s*async\\s+def\\s+(test_\\w+)\\s*\\(",
+          "function_name_group": 1,
+          "description": "pytest async function"
+        }
+      ],
+      "body_terminator": "dedent_to_def_level"
+    },
+    "typescript": {
+      "file_globs": ["**/*.test.ts", "**/*.test.tsx", "**/*.spec.ts", "**/*.spec.tsx", "**/__tests__/**/*.ts", "**/__tests__/**/*.tsx"],
+      "patterns": [
+        {
+          "regex": "\\bit\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "jest/vitest/mocha it()"
+        },
+        {
+          "regex": "\\btest\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "jest/vitest test()"
+        },
+        {
+          "regex": "\\bdescribe\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "describe() block (counted for grouping, not as a leaf test)",
+          "is_group": true
+        }
+      ],
+      "body_terminator": "balanced_braces"
+    },
+    "javascript": {
+      "file_globs": ["**/*.test.js", "**/*.test.jsx", "**/*.spec.js", "**/*.spec.jsx", "**/__tests__/**/*.js", "**/__tests__/**/*.jsx"],
+      "patterns": [
+        {
+          "regex": "\\bit\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "jest/vitest/mocha it()"
+        },
+        {
+          "regex": "\\btest\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "jest/vitest test()"
+        },
+        {
+          "regex": "\\bdescribe\\s*\\(\\s*['\"`]([^'\"`]+)['\"`]",
+          "function_name_group": 1,
+          "description": "describe() block",
+          "is_group": true
+        }
+      ],
+      "body_terminator": "balanced_braces"
+    },
+    "go": {
+      "file_globs": ["**/*_test.go"],
+      "patterns": [
+        {
+          "regex": "^func\\s+(Test\\w+)\\s*\\(",
+          "function_name_group": 1,
+          "description": "standard Go test function"
+        },
+        {
+          "regex": "^func\\s+(Benchmark\\w+)\\s*\\(",
+          "function_name_group": 1,
+          "description": "Go benchmark function"
+        }
+      ],
+      "body_terminator": "balanced_braces"
+    },
+    "ruby": {
+      "file_globs": ["**/test_*.rb", "**/*_test.rb", "**/*_spec.rb", "**/spec/**/*.rb", "**/test/**/*.rb"],
+      "patterns": [
+        {
+          "regex": "^\\s*def\\s+(test_\\w+)",
+          "function_name_group": 1,
+          "description": "Minitest / Test::Unit function"
+        },
+        {
+          "regex": "\\bit\\s+['\"]([^'\"]+)['\"]",
+          "function_name_group": 1,
+          "description": "RSpec it block"
+        }
+      ],
+      "body_terminator": "end_keyword"
+    },
+    "rust": {
+      "file_globs": ["**/*.rs"],
+      "patterns": [
+        {
+          "regex": "#\\[test\\]\\s*(?:\\n\\s*#\\[[^\\]]+\\])*\\s*\\n\\s*(?:pub\\s+)?(?:async\\s+)?fn\\s+(\\w+)",
+          "function_name_group": 1,
+          "description": "Rust #[test] attribute"
+        },
+        {
+          "regex": "#\\[tokio::test\\]\\s*\\n\\s*(?:pub\\s+)?async\\s+fn\\s+(\\w+)",
+          "function_name_group": 1,
+          "description": "Tokio async test attribute"
+        }
+      ],
+      "body_terminator": "balanced_braces"
+    }
+  },
+  "import_patterns": {
+    "python": [
+      {"regex": "^\\s*from\\s+([\\w\\.]+)\\s+import\\s+", "target_group": 1, "resolution": "dots_to_slashes_plus_py"},
+      {"regex": "^\\s*import\\s+([\\w\\.]+)", "target_group": 1, "resolution": "dots_to_slashes_plus_py"}
+    ],
+    "typescript": [
+      {"regex": "from\\s+['\"]([\\./][^'\"]+)['\"]", "target_group": 1, "resolution": "relative_path"},
+      {"regex": "require\\s*\\(\\s*['\"]([\\./][^'\"]+)['\"]\\s*\\)", "target_group": 1, "resolution": "relative_path"}
+    ],
+    "javascript": [
+      {"regex": "from\\s+['\"]([\\./][^'\"]+)['\"]", "target_group": 1, "resolution": "relative_path"},
+      {"regex": "require\\s*\\(\\s*['\"]([\\./][^'\"]+)['\"]\\s*\\)", "target_group": 1, "resolution": "relative_path"}
+    ],
+    "go": [
+      {"regex": "import\\s+['\"]([^'\"]+)['\"]", "target_group": 1, "resolution": "go_module"}
+    ],
+    "ruby": [
+      {"regex": "require(?:_relative)?\\s+['\"]([^'\"]+)['\"]", "target_group": 1, "resolution": "rb_require"}
+    ],
+    "rust": [
+      {"regex": "^\\s*use\\s+(crate::[\\w:]+)", "target_group": 1, "resolution": "rust_crate_path"}
+    ]
+  }
+}
@@ -0,0 +1,173 @@
+#!/usr/bin/env bash
+# impact-hint.sh — Files-likely-affected hint for the /add:implementer skill.
+#
+# Implements section D of specs/test-deletion-guardrail.md (AC-018..AC-024).
+#
+# Pure shell + jq + grep. No graph libraries, no AST parsers. The hint is
+# intentionally lightweight and lossy — false positives are preferred over
+# false negatives; the implementer uses this as a starting point, not a
+# ground truth.
+#
+# Usage:
+#   core/lib/impact-hint.sh <base-sha> <spec-path> [project-root]
+#
+# Emits to stdout a structured prompt block:
+#
+#   Files likely to need changes:
+#     - path/a.py
+#     - path/b.ts
+#   Files to be careful around (recent anti-pattern learnings exist):
+#     - path/c.py  [L-042]
+#
+# Exit codes:
+#   0 — hint produced (even if lists are empty)
+#   1 — invocation error
+
+set -euo pipefail
+
+BASE_SHA="${1:-}"
+SPEC_PATH="${2:-}"
+PROJECT_ROOT="${3:-$(pwd)}"
+
+if [ -z "$BASE_SHA" ] || [ -z "$SPEC_PATH" ]; then
+  echo "Usage: impact-hint.sh <base-sha> <spec-path> [project-root]" >&2
+  exit 1
+fi
+
+cd "$PROJECT_ROOT"
+
+# -- AC-018: diff between base and HEAD to find test files changed --
+CHANGED_FILES=$(git diff --name-only "$BASE_SHA"..HEAD 2>/dev/null || true)
+
+# -- Filter to test files (heuristic: path includes "test" or "spec", or suffix matches) --
+TEST_FILES=$(printf '%s\n' "$CHANGED_FILES" | grep -E \
+  '(^test_|_test\.|\.test\.|\.spec\.|/tests?/|/__tests__/|/spec/)' || true)
+
+# -- AC-019: regex-extract imports and resolve to local paths --
+IMPORT_PATHS=$(mktemp)
+trap 'rm -f "$IMPORT_PATHS" "$SPEC_PATHS" "$LEARNING_PATHS" "$CANDIDATES"' EXIT
+: > "$IMPORT_PATHS"
+
+if [ -n "$TEST_FILES" ]; then
+  while IFS= read -r tf; do
+    [ -z "$tf" ] && continue
+    [ ! -f "$tf" ] && continue
+    ext="${tf##*.}"
+    case "$ext" in
+      py)
+        # from X.Y import Z  -->  X/Y.py
+        grep -E "^\s*from\s+[\w\.]+\s+import\s+" "$tf" 2>/dev/null | \
+          sed -E 's/^\s*from\s+([\w\.]+)\s+import\s+.*/\1/' | \
+          tr '.' '/' | sed 's/$/.py/' >> "$IMPORT_PATHS" || true
+        # import X.Y  -->  X/Y.py
+        grep -E "^\s*import\s+[\w\.]+" "$tf" 2>/dev/null | \
+          sed -E 's/^\s*import\s+([\w\.]+).*/\1/' | \
+          tr '.' '/' | sed 's/$/.py/' >> "$IMPORT_PATHS" || true
+        ;;
+      ts|tsx|js|jsx|mjs|cjs)
+        # from './x/y' or require('./x/y') — capture the relative path
+        grep -E "from\s+['\"][\./][^'\"]+['\"]" "$tf" 2>/dev/null | \
+          sed -E "s/.*from\s+['\"]([\./][^'\"]+)['\"].*/\1/" >> "$IMPORT_PATHS" || true
+        grep -E "require\s*\(\s*['\"][\./][^'\"]+['\"]\s*\)" "$tf" 2>/dev/null | \
+          sed -E "s/.*require\s*\(\s*['\"]([\./][^'\"]+)['\"]\s*\).*/\1/" >> "$IMPORT_PATHS" || true
+        ;;
+      go)
+        grep -E "^\s*import\s+\"[^\"]+\"" "$tf" 2>/dev/null | \
+          sed -E 's/^\s*import\s+"([^"]+)".*/\1/' >> "$IMPORT_PATHS" || true
+        ;;
+      rb)
+        grep -E "^\s*require(_relative)?\s+['\"][^'\"]+['\"]" "$tf" 2>/dev/null | \
+          sed -E "s/.*require(_relative)?\s+['\"]([^'\"]+)['\"].*/\2/" >> "$IMPORT_PATHS" || true
+        ;;
+      rs)
+        grep -E "^\s*use\s+crate::" "$tf" 2>/dev/null | \
+          sed -E 's|^\s*use\s+crate::([a-zA-Z_0-9:]+).*|\1|' | \
+          sed 's|::|/|g' | sed 's/$/.rs/' >> "$IMPORT_PATHS" || true
+        ;;
+    esac
+  done <<< "$TEST_FILES"
+fi
+
+# Normalize: strip leading ./, drop duplicates, keep only paths that exist in repo
+RESOLVED_IMPORTS=$(sort -u "$IMPORT_PATHS" | while IFS= read -r p; do
+  [ -z "$p" ] && continue
+  p="${p#./}"
+  # Try the path as-is, plus common extension variants
+  for candidate in "$p" "${p%.py}.py" "${p%.ts}.ts" "${p%.js}.js" "$p/index.ts" "$p/index.js" "$p/__init__.py"; do
+    if [ -f "$candidate" ]; then
+      echo "$candidate"
+      break
+    fi
+  done
+done | sort -u)
+
+# -- AC-020: cross-reference literal path mentions in the spec --
+SPEC_PATHS=$(mktemp)
+: > "$SPEC_PATHS"
+if [ -f "$SPEC_PATH" ]; then
+  # Extract any token matching filename.ext where ext is a known source extension
+  grep -oE '[A-Za-z0-9_./-]+\.(py|ts|tsx|js|jsx|go|rs|rb|mjs|cjs)' "$SPEC_PATH" 2>/dev/null | \
+    sort -u > "$SPEC_PATHS" || true
+fi
+
+SPEC_PATHS_EXISTING=$(while IFS= read -r p; do
+  [ -z "$p" ] && continue
+  # Only surface paths that exist AND are not themselves test files
+  if [ -f "$p" ]; then
+    echo "$p" | grep -vE '(^test_|_test\.|\.test\.|\.spec\.|/tests?/|/__tests__/|/spec/)' || true
+  fi
+done < "$SPEC_PATHS" | sort -u)
+
+# -- Union: candidate source files --
+CANDIDATES=$(mktemp)
+{
+  echo "$RESOLVED_IMPORTS"
+  echo "$SPEC_PATHS_EXISTING"
+} | sort -u | grep -v '^$' > "$CANDIDATES" || true
+
+# -- AC-021: anti-pattern learnings lookup --
+LEARNINGS_FILE="$PROJECT_ROOT/.add/learnings.json"
+LEARNING_PATHS=$(mktemp)
+: > "$LEARNING_PATHS"
+
+if [ -f "$LEARNINGS_FILE" ] && command -v jq >/dev/null 2>&1; then
+  # Build a { "path": "L-###" } list by scanning anti-pattern bodies
+  while IFS= read -r candidate; do
+    [ -z "$candidate" ] && continue
+    # Find anti-pattern entries whose body mentions this path
+    match=$(jq -r --arg p "$candidate" '
+      .entries[]? // empty |
+      select(.category == "anti-pattern") |
+      select(.body | test($p; "i")) |
+      .id
+    ' "$LEARNINGS_FILE" 2>/dev/null | head -1 || true)
+    if [ -n "$match" ]; then
+      echo "$candidate|$match" >> "$LEARNING_PATHS"
+    fi
+  done < "$CANDIDATES"
+fi
+
+# -- Emit the hint --
+echo "## Files likely to need changes"
+if [ ! -s "$CANDIDATES" ]; then
+  # AC-024: explicit no-source-files message
+  echo "  (No source files implied by RED diff. Check spec acceptance criteria"
+  echo "   for implementation targets.)"
+else
+  # Exclude anti-pattern paths from this list (they get their own section)
+  FLAGGED_PATHS=$(cut -d'|' -f1 < "$LEARNING_PATHS" 2>/dev/null | sort -u)
+  while IFS= read -r p; do
+    [ -z "$p" ] && continue
+    if ! printf '%s\n' "$FLAGGED_PATHS" | grep -qxF "$p" 2>/dev/null; then
+      echo "  - $p"
+    fi
+  done < "$CANDIDATES"
+fi
+
+if [ -s "$LEARNING_PATHS" ]; then
+  echo ""
+  echo "## Files to be careful around (recent anti-pattern learnings exist)"
+  while IFS='|' read -r path lid; do
+    echo "  - $path  [$lid]"
+  done < "$LEARNING_PATHS"
+fi
@@ -46,6 +46,63 @@ All implementation follows strict TDD. The cycle is RED → GREEN → REFACTOR
 - When a sub-agent implements code, the orchestrator MUST run tests independently
 - Each TDD cycle should be a single, atomic commit
 
+## Test-Deletion Invariant (v0.9.0 / M3)
+
+**Tests added during RED MUST exist (passing) at the end of GREEN.** Test deletion during
+the cycle is forbidden without `--allow-test-rewrite` **and** explicit human approval.
+Test renames are permitted (same normalized body, different function name); test
+replacements (same name, rewritten body beyond the similarity threshold) require
+approval.
+
+This invariant is enforced at three points:
+
+1. **End of RED** — `/add:test-writer` writes a snapshot at
+   `.add/cycles/cycle-{N}/tdd-{slug}-red.json` capturing every test function's path,
+   name, and normalized body hash. The snapshot is committed (`test(red): snapshot N
+   tests for {slug}`). Failure mode: if RED produces zero new tests, the cycle halts —
+   RED with no new tests is itself a TDD violation.
+2. **End of GREEN** — `/add:implementer` re-runs discovery against the same files and
+   writes `.add/cycles/cycle-{N}/tdd-{slug}-green.json` with identical schema.
+3. **Gate 3.5 in `/add:verify`** — runs `scripts/check-test-count.py gate --red ... --green ...`.
+   If `tests_removed > 0` without an override, or `tests_replaced > 0` without
+   `--allow-test-rewrite`, the gate fails with a structured error listing each removed
+   or replaced test. The cycle does not advance to Gate 4.
+
+### Justification markers
+
+A test deletion or replacement is authorized by **either**:
+
+- A commit trailer in the range `base..HEAD` of the form
+  `[ADD-TEST-DELETE: <AC-id or reason>]`. Used for out-of-cycle rewrites or small
+  maintenance changes.
+- A file at `.add/cycles/cycle-{N}/overrides.json` of shape:
+
+  ```json
+  {
+    "kind": "test-rewrite",
+    "approved_by": "human",
+    "timestamp": "2026-04-22T14:32:00Z",
+    "affected_tests": ["tests/path.py::function_name"]
+  }
+  ```
+
+Either form is recorded in telemetry and surfaced in `/add:retro` for review.
+
+### Rationale
+
+The genie doesn't want to do TDD (Kent Beck, 2026) — the path of least resistance for a
+coding agent is to remove the failing test rather than satisfy it. The TDAD paper
+(arXiv 2603.17973) observed naive TDD-prompting *increased* regression rate to 9.94%
+because agents silently deleted tests they couldn't satisfy. ADD's separation of concerns
+(test-writer vs implementer) only matters if the tests written in RED survive GREEN.
+This invariant enforces that.
+
+### Why both markers are accepted
+
+Some TDD-cycle runs are fully scripted (`--allow-test-rewrite` with an `overrides.json`
+approval); others are ad-hoc developer work where a commit trailer is the lighter-weight
+signal. Both land in the same telemetry channel so retros can review legitimacy.
+
 ## Test Naming
 
 Tests must reference the spec: