[Bounty: $95] Add unit tests for the env.ts config loaders loadEmailJSConfig, loadSupabaseConfig and loadAdminConfig

[Onis2254]

Context
tests/lib/env.test.ts only covers isAdminEmail/isDevelopment/isProduction. The loaders in lib/env.ts (loadEmailJSConfig 142-165, loadSupabaseConfig 168-185, loadAdminConfig 188-197) and the requireEnv/getEnv helpers (76-99) with their error-accumulation, whitespace-as-missing and list-normalization behaviour are untested.

Proposed Change
Extend tests/lib/env.test.ts to stub env per case and assert: each missing required field pushes one error with the right message; whitespace-only values count as missing; loadEmailJSConfig leaves the default recipient undefined when unset; loadAdminConfig trims/lowercases entries, drops empties and returns [] for blank or comma-only strings.

Acceptance Criteria

• Errors arrays and messages are asserted per loader under vi.stubEnv
• Whitespace-only and empty-list cases are covered
• npm run test passes

Suggested Label: tests

ETA: 24 hours

[zhangb06]

Claiming this bounty - PR #258 submitted.

[Ranjeet2063]

Submitted PR #303 to address this issue.

Implementation Summary:

• Extended tests/lib/env.test.ts with unit tests for loadEmailJSConfig, loadSupabaseConfig, loadAdminConfig, and loadStellarConfig.
• Asserted validation error arrays and messages when required env vars are missing or whitespace-only.
• Verified email trimming, lowercasing, and empty-filtering in loadAdminConfig.
• 2x verified locally: test suite passed (21/21 tests in env.test.ts), npm run type-check passed, npm run lint passed, and Prettier formatting is clean.

[rafaio1]

/claim

[Zhiyilang074811]

PR submitted: #216

Added 141 lines of unit tests covering loadEmailJSConfig, loadSupabaseConfig, loadAdminConfig, and validateEnv error accumulation.

/bounty claim 3rb3NNaU5foZFvVk4faVuMmqMvoxfADW3Xw5Wv5vfZr6

[rafaio1]

/claim

[woahwhattheheck]

Registering intent on this issue, and linking the work: #374 covers the three loaders, the error accumulation, whitespace-as-missing and the admin list normalization.

Two notes from doing it. The tests live in a new tests/lib/env-loaders.test.ts rather than being appended to tests/lib/env.test.ts, because my PR #374's sibling (#364, for issue #108) already edits that file and the two would conflict textually for no reason — happy to merge them into one file once either lands. And the issue asks that an unset default recipient be undefined, but getEnv(name, defaultValue = "") returns an empty string, so the test pins the empty string the code actually produces rather than an assertion that fails on main. The one-line change to get the documented behaviour is described in the PR if you want it.

Noting the process explicitly, since CONTRIBUTING is clear that this is not first-to-merge and that Step 2 asks for a GrantFox application before implementation: I have not filed a GrantFox milestone/bounty application for this issue, so there is no id to reference in the PR description yet. Happy to file one under whatever identity you would like the work attributed to, or to have the PR treated as an ordinary contribution if this issue is not tied to a funded milestone. I am not claiming any reward here.

[moyuziya]

I read CONTRIBUTING.md and would like to apply for #94 through the required GrantFox workflow. The public GrantFox project search for Mova and issue search for loadEmailJSConfig currently return no results. Could you share the corresponding application/milestone URL and confirm whether the advertised $95 is funded and still available?

My proposed scope is isolated Vitest cases for each loader’s error accumulation, whitespace-only input, optional recipient behavior, and normalized admin lists. I would clarify the documented undefined recipient versus current empty-string behavior before pinning an expectation, and run the required tests, type check, lint, and build. I see the existing competing PRs and am not requesting exclusivity. I have not started implementation or claimed a reward; I will wait for the required application acknowledgement.