Checkpoint before new AI session.

Deletes the one problematic test and starts on a proper code coverage journey instead. Two temp plan docs included.

Author: Cervator

config/gradle/common.gradle

@@ -43,3 +43,21 @@ tasks.javadoc {
     // TODO: Temporary until javadoc has been fixed for Java 8 everywhere
     failOnError = false
 }
+
+apply plugin: 'jacoco'
+
+jacoco {
+    toolVersion = "0.8.13"
+}
+
+test {
+    finalizedBy jacocoTestReport
+}
+
+jacocoTestReport {
+    dependsOn test
+    reports {
+        xml.required = true
+        html.required = true
+    }
+}

engine-tests/build.gradle.kts

@@ -164,3 +164,19 @@ idea {
         isDownloadSources = true
     }
 }
+
+tasks.named<org.gradle.testing.jacoco.tasks.JacocoReport>("jacocoTestReport") {
+    // Cross-module support: The tests in this module (:engine-tests) exercise code located in the :engine module.
+    // By default, JaCoCo only looks at sources in the current project. We must explicitly add the :engine
+    // main source set and output classes so that the coverage report includes the actual engine code.
+    val engineProject = project(":engine")
+    val sourceSets = engineProject.extensions.getByType(SourceSetContainer::class)
+    val mainSourceSet = sourceSets.getByName("main")
+
+    additionalSourceDirs.from(mainSourceSet.allSource)
+    additionalClassDirs.from(mainSourceSet.output)
+    reports {
+        xml.required.set(true)
+        html.required.set(true)
+    }
+}

engine-tests/src/test/java/org/terasology/metatesting/NetworkEventTest.java

@@ -0,0 +1,21 @@
+# Future Tasks Roadmap
+
+## 1. MTE Module Synchronization
+*   **Context**: Changes were made to `EntitySystemSetupUtil` and `NetworkEventSystemDecorator` in the `engine` to fix network event propagation in tests.
+*   **Task**: Propagate these changes to the standalone `ModuleTestingEnvironment` module (located in `modules/ModuleTestingEnvironment`).
+    *   Compare `engine` implementation with `ModuleTestingEnvironment` implementation.
+    *   Apply the `NetworkEventSystemDecorator` wrapping logic to the MTE module's initialization code.
+*   **Verification**: Run tests within the `ModuleTestingEnvironment` module to ensure no regressions and that network events propagate correctly there as well.
+
+## 2. Record & Replay System
+*   **Context**: The user mentioned diving into the record & replay system after MTE work is stabilized.
+*   **Task**: Investigate the current state of the Record & Replay system.
+    *   Assess if the recent `NetworkEventSystemDecorator` changes impact recording/replaying of events.
+    *   Create/Run tests specifically for Record & Replay scenarios.
+
+## 3. Networking Coverage Expansion
+*   **Context**: JaCoCo analysis identified gaps in `org.terasology.engine.network`.
+*   **Task**: Implement tests for:
+    *   `ServerInfoService`
+    *   `PingService` / `PingComponent`
+    *   `ServerPingSystem` / `ClientPingSystem`

future_tasks.md

@@ -0,0 +1,30 @@
+# Testing Plan & Session Summary
+
+## Recent Work Completed
+1.  **Fixed Network Event Propagation**:
+    *   Diagnosed and fixed `UncheckedTimeoutException` in `MTETwoClientChatTest`.
+    *   Root cause: `EventSystemImpl` was not being wrapped with `NetworkEventSystemDecorator` in the MTE initialization, causing network events to be treated as local.
+    *   Fix: Updated `EntitySystemSetupUtil.java` to use `NetworkEventSystemDecorator` when networking is enabled.
+    *   Verified: `MTETwoClientChatTest` now passes.
+
+2.  **Code Coverage Analysis (JaCoCo)**:
+    *   Integrated JaCoCo into `common.gradle` and `engine-tests/build.gradle.kts` (with cross-module support).
+    *   Analyzed `org.terasology.engine.network` package.
+    *   **Findings**: ~50% instruction coverage.
+    *   For Jenkins enable JaCoCo somehow but only store the XML report (past issues led to immense JaCoCo storage usage)
+
+## Coverage Gaps & Priorities
+The following areas in `org.terasology.engine.network` have significant coverage gaps and should be prioritized in the next testing round:
+
+### High Priority (0% Coverage)
+*   **`ServerInfoService`** (142 missed instructions): Completely untested. Critical for server discovery/info.
+*   **`PingService`** (41 missed instructions): Untested.
+*   **`PingComponent`** (27 missed instructions): Untested.
+*   **`ClientPingSystem`** (18 missed instructions): Untested.
+
+### Medium Priority (Partial Coverage)
+*   **`ServerPingSystem`** (134 missed instructions): Partially covered, but likely missing edge cases or specific scenarios.
+
+## Strategy for Next Session
+1.  **Targeted Unit Tests**: Create a new test class (e.g., `ServerInfoServiceTest`) to specifically target `ServerInfoService`.
+2.  **Integration Tests**: Expand `NetworkEventPropagationTest` or create a new MTE test to cover Ping functionality (`PingService`, `ServerPingSystem`, `ClientPingSystem`).