Skip to content

Commit 428dfcd

Browse files
[grizzly] Use a separate token for reducer tasks.
These tasks required read/write access to FuzzManager.
1 parent cdab72b commit 428dfcd

File tree

9 files changed

+25
-10
lines changed

9 files changed

+25
-10
lines changed

services/grizzly-macos/launch.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,14 @@ EOF
8989
fluent-bit -c td-agent-bit.conf &
9090

9191
# Get fuzzmanager configuration from TC
92+
if [ "$ADAPTER" = "reducer" ]
93+
then
94+
fmsecret=fuzzmanagerconf-rw
95+
else
96+
fmsecret=fuzzmanagerconf
97+
fi
9298
set +x
93-
retry_curl "$TASKCLUSTER_PROXY_URL/secrets/v1/secret/project/fuzzing/fuzzmanagerconf" | python -c "import json,sys;open('.fuzzmanagerconf','w').write(json.load(sys.stdin)['secret']['key'])"
99+
retry_curl "$TASKCLUSTER_PROXY_URL/secrets/v1/secret/project/fuzzing/$fmsecret" | python -c "import json,sys;open('.fuzzmanagerconf','w').write(json.load(sys.stdin)['secret']['key'])"
94100
set -x
95101
export FM_CONFIG_PATH="$PWD/.fuzzmanagerconf"
96102

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/common.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ def _list_objs(
125125
)
126126

127127
while next_url:
128-
129128
resp_json = self.get(next_url, params=params).json()
130129

131130
if isinstance(resp_json, dict):
@@ -237,7 +236,7 @@ def ensure_credentials() -> None:
237236
# get fuzzmanager config from taskcluster
238237
conf_path = Path.home() / ".fuzzmanagerconf"
239238
if not conf_path.is_file():
240-
key = Taskcluster.load_secrets("project/fuzzing/fuzzmanagerconf")["key"]
239+
key = Taskcluster.load_secrets("project/fuzzing/fuzzmanagerconf-rw")["key"]
241240
conf_path.write_text(key)
242241
conf_path.chmod(0o400)
243242

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/monitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ def _fuzzmanager_get_crashes(
133133
)
134134

135135
buckets_by_tool: Dict[str, List[str]] = {}
136-
for (bucket, tool) in bucket_tools:
136+
for bucket, tool in bucket_tools:
137137
buckets_by_tool.setdefault(tool, [])
138138
buckets_by_tool[tool].append(bucket)
139139
for tool, bucket_filter in buckets_by_tool.items():

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/task_templates/reduce-android.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ scopes:
4545
- "docker-worker:capability:privileged"
4646
- "secrets:get:project/fuzzing/deploy-bearspray"
4747
- "secrets:get:project/fuzzing/deploy-grizzly-private"
48-
- "secrets:get:project/fuzzing/fuzzmanagerconf"
48+
- "secrets:get:project/fuzzing/fuzzmanagerconf-rw"
4949
- "secrets:get:project/fuzzing/google-logging-creds"
5050
taskGroupId: "${task_group}"
5151
workerType: "${worker}"

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/task_templates/reduce-macos.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ schedulerId: "${scheduler}"
5151
scopes:
5252
- "secrets:get:project/fuzzing/deploy-bearspray"
5353
- "secrets:get:project/fuzzing/deploy-grizzly-private"
54-
- "secrets:get:project/fuzzing/fuzzmanagerconf"
54+
- "secrets:get:project/fuzzing/fuzzmanagerconf-rw"
5555
- "secrets:get:project/fuzzing/google-logging-creds"
5656
taskGroupId: "${task_group}"
5757
workerType: "${worker}"

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/task_templates/reduce-windows.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ scopes:
5656
- "generic-worker:run-as-administrator:${provisioner}/grizzly-reduce-worker-windows"
5757
- "secrets:get:project/fuzzing/deploy-bearspray"
5858
- "secrets:get:project/fuzzing/deploy-grizzly-private"
59-
- "secrets:get:project/fuzzing/fuzzmanagerconf"
59+
- "secrets:get:project/fuzzing/fuzzmanagerconf-rw"
6060
- "secrets:get:project/fuzzing/google-logging-creds"
6161
taskGroupId: "${task_group}"
6262
workerType: "${worker}"

services/grizzly-reduce-monitor/src/grizzly_reduce_monitor/task_templates/reduce.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ scopes:
4040
- "docker-worker:capability:device:loopbackAudio"
4141
- "secrets:get:project/fuzzing/deploy-bearspray"
4242
- "secrets:get:project/fuzzing/deploy-grizzly-private"
43-
- "secrets:get:project/fuzzing/fuzzmanagerconf"
43+
- "secrets:get:project/fuzzing/fuzzmanagerconf-rw"
4444
- "secrets:get:project/fuzzing/google-logging-creds"
4545
taskGroupId: "${task_group}"
4646
workerType: "${worker}"

services/grizzly-win/launch.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,14 @@ EOF
7878
retry pip install git+https://github.com/MozillaSecurity/FuzzManager
7979

8080
# Get fuzzmanager configuration from TC
81+
if [ "$ADAPTER" = "reducer" ]
82+
then
83+
fmsecret=fuzzmanagerconf-rw
84+
else
85+
fmsecret=fuzzmanagerconf
86+
fi
8187
set +x
82-
retry_curl "$TASKCLUSTER_PROXY_URL/secrets/v1/secret/project/fuzzing/fuzzmanagerconf" | python -c "import json,sys;open('.fuzzmanagerconf','w').write(json.load(sys.stdin)['secret']['key'])"
88+
retry_curl "$TASKCLUSTER_PROXY_URL/secrets/v1/secret/project/fuzzing/$fmsecret" | python -c "import json,sys;open('.fuzzmanagerconf','w').write(json.load(sys.stdin)['secret']['key'])"
8389
set -x
8490

8591
# Update fuzzmanager config for this instance

services/grizzly/launch-grizzly-worker.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ pushd /src/fuzzmanager >/dev/null
2222
popd >/dev/null
2323

2424
# Get fuzzmanager configuration from TC
25-
get-tc-secret fuzzmanagerconf .fuzzmanagerconf
25+
if [[ "$ADAPTER" = "reducer" ]]; then
26+
get-tc-secret fuzzmanagerconf-rw .fuzzmanagerconf
27+
else
28+
get-tc-secret fuzzmanagerconf .fuzzmanagerconf
29+
fi
2630

2731
# Update fuzzmanager config for this instance
2832
mkdir -p signatures

0 commit comments

Comments
 (0)