-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
Description
Currently we require most fields to be identical for the whole set of apply_to configs.
orion/services/fuzzing-decision/src/fuzzing_decision/common/pool.py
Lines 693 to 707 in f0b0b0b
| # while these fields are not required to be defined here, they must be the same | |
| # for the entire set .. at least for now | |
| same_fields = ( | |
| "cloud", | |
| "cores_per_task", | |
| "cpu", | |
| "cycle_time", | |
| "disk_size", | |
| "gpu", | |
| "imageset", | |
| "metal", | |
| "minimum_memory_per_core", | |
| "platform", | |
| "schedule_start", | |
| ) |
This allows a shortcut later on where those values are set in the parent pool to be used by the decision somehow (according to the comment).
orion/services/fuzzing-decision/src/fuzzing_decision/common/pool.py
Lines 714 to 715 in f0b0b0b
| # set the field on self, so it can easily be used by decision | |
| setattr(self, field, getattr(pools[0], field)) |
This shouldn't be necessary. It prevents us from creating a pool (eg. with macro COVERAGE=1) that applies to pools in disparate clouds or different OS'.