Merge pull request #93 from MrClock8163/feature/update-download-return-type

Update download methods to return bytes

Author: MrClock8163

CHANGELOG.md

@@ -21,6 +21,8 @@ The project uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 - Renamed `parsebool` to `parse_bool`
 - Renamed `toenum` to `get_enum`
 - Renamed `enumparser` to `get_enum_parser`
+- Updated GeoCOM FTR `download` to return `bytes` instead of `str`
+- Updated GeoCOM FTR `download_large` to return `bytes` instead of `str`
 
 ### Fixed
 

src/geocompy/geo/ftr.py

@@ -238,7 +238,7 @@ def setup_download(
     def download(
         self,
         block: int
-    ) -> GeoComResponse[str]:
+    ) -> GeoComResponse[bytes]:
         """
         RPC 23304, ``FTR_Download``
 
@@ -248,13 +248,13 @@ def download(
         Parameters
         ----------
         block : int
-            Number of data block to download.
+            Index of data block to download.
 
         Returns
         -------
         GeoComResponse
             Params:
-                - `str`: Data block as hexadecimal byte string.
+                - `bytes`: Data block.
 
             Error codes:
                 - ``FTR_MISSINGSETUP``: No active download setup.
@@ -270,7 +270,7 @@ def download(
         return self._request(
             23304,
             [block],
-            parse_string
+            lambda data: bytes.fromhex(parse_string(data))
         )
 
     def abort_download(self) -> GeoComResponse[None]:
@@ -468,7 +468,7 @@ def setup_large_download(
     def download_large(
         self,
         block: int
-    ) -> GeoComResponse[str]:
+    ) -> GeoComResponse[bytes]:
         """
         RPC 23314, ``FTR_DownloadXL``
 
@@ -480,13 +480,13 @@ def download_large(
         Parameters
         ----------
         block : int
-            Number of data block to download.
+            Index of data block to download.
 
         Returns
         -------
         GeoComResponse
             Params:
-                - `str`: Data block as hexadecimal byte string.
+                - `bytes`: Data block.
 
             Error codes:
                 - ``FTR_MISSINGSETUP``: No active download setup.
@@ -502,5 +502,5 @@ def download_large(
         return self._request(
             23314,
             [block],
-            parse_string
+            lambda data: bytes.fromhex(parse_string(data))
         )