Skip to content

Commit 363bd57

Browse files
committed
[geocom, gsidna] fixed exception logging
1 parent f212993 commit 363bd57

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/geocompy/geo/__init__.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
"""
3939
import re
4040
from logging import Logger
41-
from traceback import format_exc
4241
from time import sleep
4342
from enum import Enum
4443
from typing import Any, overload, TypeVar
@@ -359,19 +358,19 @@ def request(
359358
try:
360359
answer = self._conn.exchange(cmd)
361360
except SerialTimeoutException:
362-
self._logger.error(format_exc())
361+
self._logger.exception("Connection timed out during request")
363362
answer = (
364363
f"%R1P,{GeoComCode.COM_TIMEDOUT:d},"
365364
f"{trid}:{GeoComCode.OK:d}"
366365
)
367366
except SerialException:
368-
self._logger.error(format_exc())
367+
self._logger.exception("Connection error occured during request")
369368
answer = (
370369
f"%R1P,{GeoComCode.COM_CANT_SEND:d},"
371370
f"{trid}:{GeoComCode.OK:d}"
372371
)
373372
except Exception:
374-
self._logger.error(format_exc())
373+
self._logger.exception("Unknown error occured during request")
375374
answer = (
376375
f"%R1P,{GeoComCode.COM_FAILED:d},"
377376
f"{trid}:{GeoComCode.OK:d}"

src/geocompy/gsi/dna/__init__.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import re
2525
from typing import TypeVar
2626
from collections.abc import Callable
27-
from traceback import format_exc
2827
from logging import Logger
2928
from time import sleep
3029

@@ -208,7 +207,7 @@ def setrequest(
208207
try:
209208
answer = self._conn.exchange(cmd)
210209
except Exception:
211-
self._logger.error(format_exc())
210+
self._logger.exception("Error occured during SET request")
212211
answer = _UNKNOWNERROR
213212
comment = "EXCHANGE"
214213
value = answer == "?"
@@ -251,7 +250,7 @@ def confrequest(
251250
try:
252251
answer = self._conn.exchange(cmd)
253252
except Exception:
254-
self._logger.error(format_exc())
253+
self._logger.exception("Error occured during CONF request")
255254
answer = _UNKNOWNERROR
256255
comment = "EXCHANGE"
257256

@@ -299,7 +298,7 @@ def putrequest(
299298
try:
300299
answer = self._conn.exchange(cmd)
301300
except Exception:
302-
self._logger.error(format_exc())
301+
self._logger.exception("Error occured during PUT request")
303302
answer = _UNKNOWNERROR
304303
comment = "EXCHANGE"
305304
value = answer == "?"
@@ -343,7 +342,7 @@ def getrequest(
343342
try:
344343
answer = self._conn.exchange(cmd)
345344
except Exception:
346-
self._logger.error(format_exc())
345+
self._logger.exception("Error occured during GET request")
347346
answer = _UNKNOWNERROR
348347
comment = "EXCHANGE"
349348

@@ -392,7 +391,7 @@ def request(
392391
try:
393392
answer = self._conn.exchange(cmd)
394393
except Exception:
395-
self._logger.error(format_exc())
394+
self._logger.exception("Error occured during request")
396395
answer = _UNKNOWNERROR
397396
comment = "EXCHANGE"
398397

0 commit comments

Comments
 (0)