Skip to content

Commit c4c974e

Browse files
committed
Fixed missing annotations in src
1 parent 394b0de commit c4c974e

File tree

11 files changed

+50
-33
lines changed

11 files changed

+50
-33
lines changed

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,6 @@ version-file = "src/geocompy/_version.py"
6868
addopts = ["-ra", "-v", "--color=yes"]
6969
testpaths = ["tests"]
7070
required_plugins = "pytest-mock"
71+
72+
[tool.mypy]
73+
strict = true

src/geocompy/communication.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def is_open(self) -> bool:
113113
"""
114114
raise NotImplementedError("interface does not implement 'is_open'")
115115

116-
def send(self, message: str):
116+
def send(self, message: str) -> None:
117117
"""
118118
Sends a single serialized message through the connection.
119119
@@ -296,7 +296,7 @@ def __init__(
296296
if not self._port.is_open:
297297
self._port.open()
298298

299-
def __del__(self):
299+
def __del__(self) -> None:
300300
self._port.close()
301301

302302
def __enter__(self) -> SerialConnection:
@@ -307,10 +307,10 @@ def __exit__(
307307
exc_type: BaseException,
308308
exc_value: BaseException,
309309
exc_tb: TracebackType
310-
):
310+
) -> None:
311311
self._port.close()
312312

313-
def close(self):
313+
def close(self) -> None:
314314
"""
315315
Closes the serial port.
316316
"""
@@ -328,7 +328,7 @@ def is_open(self) -> bool:
328328
"""
329329
return self._port.is_open
330330

331-
def send(self, message: str):
331+
def send(self, message: str) -> None:
332332
"""
333333
Writes a single message to the serial line.
334334

src/geocompy/data.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,10 @@
3434
TypeAlias,
3535
Literal,
3636
Callable,
37+
Iterator,
3738
TypeVar,
38-
Self
39+
Self,
40+
Any
3941
)
4042

4143

@@ -758,7 +760,7 @@ def __str__(self) -> str:
758760
def __repr__(self) -> str:
759761
return str(self)
760762

761-
def __iter__(self):
763+
def __iter__(self) -> Iterator[float]:
762764
return iter([self.x, self.y, self.z])
763765

764766
def __getitem__(self, idx: int) -> float:
@@ -768,7 +770,7 @@ def __getitem__(self, idx: int) -> float:
768770
coords = (self.x, self.y, self.z)
769771
return coords[idx]
770772

771-
def __eq__(self, other) -> bool:
773+
def __eq__(self, other: Any) -> bool:
772774
if type(other) is not type(self):
773775
return False
774776

src/geocompy/protocols.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class GeoComProtocol:
179179
Base class for GeoCom protocol versions.
180180
181181
"""
182-
_R1P: re.Pattern = re.compile(
182+
_R1P: re.Pattern[str] = re.compile(
183183
r"^%R1P,"
184184
r"(?P<comrc>\d+),"
185185
r"(?P<tr>\d+):"
@@ -241,7 +241,7 @@ def request(
241241
rpc: int,
242242
params: Iterable[int | float | bool | str | Angle | Byte] = (),
243243
parsers: Iterable[Callable[[str], Any]] | None = None
244-
) -> GeoComResponse[tuple]: ...
244+
) -> GeoComResponse[tuple[Any, ...]]: ...
245245

246246
def request(
247247
self,
@@ -252,7 +252,7 @@ def request(
252252
| Callable[[str], Any]
253253
| None
254254
) = None
255-
) -> GeoComResponse:
255+
) -> GeoComResponse[Any]:
256256
"""
257257
Executes an RPC request and returns the parsed GeoCom response.
258258
@@ -345,7 +345,7 @@ def parse_response(
345345
cmd: str,
346346
response: str,
347347
parsers: Iterable[Callable[[str], Any]] | None = None
348-
) -> GeoComResponse[tuple]: ...
348+
) -> GeoComResponse[tuple[Any, ...]]: ...
349349

350350
def parse_response(
351351
self,
@@ -356,7 +356,7 @@ def parse_response(
356356
| Callable[[str], Any]
357357
| None
358358
) = None
359-
) -> GeoComResponse:
359+
) -> GeoComResponse[Any]:
360360
"""
361361
Parses RPC response and constructs :class:`GeoComResponse`
362362
instance.
@@ -402,7 +402,7 @@ def parse_response(
402402
elif not isinstance(parsers, Iterable):
403403
parsers = (parsers,)
404404

405-
params: list = []
405+
params: list[Any] = []
406406
try:
407407
for func, value in zip(parsers, values.split(",")):
408408
params.append(func(value))

src/geocompy/tps1100/csv.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..data import enumparser
@@ -106,7 +106,8 @@ def get_user_instrument_name(self) -> Never:
106106
@deprecated("This command was removed for TPS1100 instruments")
107107
def set_user_instrument_name(
108108
self,
109-
*args
109+
*args: Any,
110+
**kwargs: Any
110111
) -> Never:
111112
"""
112113
RPC 5005, ``CSV_SetUserInstrumentName``

src/geocompy/tps1100/edm.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..data import (
@@ -88,7 +88,8 @@ def set_guidelight_intensity(
8888
@deprecated("This command was removed for TPS1100 instruments")
8989
def switch_edm(
9090
self,
91-
*args
91+
*args: Any,
92+
**kwargs: Any
9293
) -> Never:
9394
"""
9495
RPC 1010, ``EDM_On``
@@ -117,7 +118,8 @@ def get_boomerang_filter_status(self) -> Never:
117118
@deprecated("This command was removed for TPS1100 instruments")
118119
def switch_boomerang_filter(
119120
self,
120-
*args
121+
*args: Any,
122+
**kwargs: Any
121123
) -> Never:
122124
"""
123125
RPC 1007, ``EDM_SetBumerang``
@@ -147,7 +149,8 @@ def get_tracklight_brightness(self) -> Never:
147149
@deprecated("This command was removed for TPS1100 instruments")
148150
def set_tracklight_brightness(
149151
self,
150-
*args
152+
*args: Any,
153+
**kwargs: Any
151154
) -> Never:
152155
"""
153156
RPC 1032, ``EDM_SetTrkLightBrightness``
@@ -178,7 +181,8 @@ def get_tracklight_status(self) -> Never:
178181
@deprecated("This command was removed for TPS1100 instruments")
179182
def switch_tracklight(
180183
self,
181-
*args
184+
*args: Any,
185+
**kwargs: Any
182186
) -> Never:
183187
"""
184188
RPC 1031, ``EDM_SetTrkLightSwitch``

src/geocompy/tps1200p/aus.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..tps1100.aus import TPS1100AUS
@@ -45,7 +45,8 @@ def get_rcs_search_status(self) -> Never:
4545
@deprecated("This command was removed for TPS1200 instruments")
4646
def switch_rcs_search(
4747
self,
48-
*args
48+
*args: Any,
49+
**kwargs: Any
4950
) -> Never:
5051
"""
5152
RPC 18009, ``AUS_SwitchRcsSearch``

src/geocompy/tps1200p/aut.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..data import toenum
@@ -49,7 +49,8 @@ def get_atr_status(self) -> Never:
4949
@deprecated("This command was removed for TPS1200 instruments")
5050
def switch_atr(
5151
self,
52-
*args
52+
*args: Any,
53+
**kwargs: Any
5354
) -> Never:
5455
"""
5556
RPC 9018, ``AUT_SetATRStatus``
@@ -78,7 +79,8 @@ def get_lock_status(self) -> Never:
7879
@deprecated("This command was removed for TPS1200 instruments")
7980
def switch_lock(
8081
self,
81-
*args
82+
*args: Any,
83+
**kwargs: Any
8284
) -> Never:
8385
"""
8486
RPC 9020, ``AUT_SetLockStatus``

src/geocompy/tps1200p/bap.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..data import (
@@ -58,7 +58,8 @@ def get_last_displayed_error(self) -> Never:
5858
@deprecated("This command was removed for TPS1200 instruments")
5959
def set_prism_definition(
6060
self,
61-
*args
61+
*args: Any,
62+
**kwargs: Any
6263
) -> Never:
6364
"""
6465
RPC 17024, ``BAP_SetPrismDef``

src/geocompy/tps1200p/com.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"""
1515
from __future__ import annotations
1616

17-
from typing import Never
17+
from typing import Never, Any
1818
from typing_extensions import deprecated
1919

2020
from ..tps1100.com import TPS1100COM
@@ -32,7 +32,8 @@ class TPS1200PCOM(TPS1100COM):
3232
@deprecated("This command was removed for TPS1200 instruments")
3333
def set_send_delay(
3434
self,
35-
*args
35+
*args: Any,
36+
**kwargs: Any
3637
) -> Never:
3738
"""
3839
RPC 109, ``COM_SetSendDelay``
@@ -48,7 +49,8 @@ def set_send_delay(
4849
@deprecated("This command was removed for TPS1200 instruments")
4950
def switch_signoff(
5051
self,
51-
*args
52+
*args: Any,
53+
**kwargs: Any
5254
) -> Never:
5355
"""
5456
RPC 115, ``COM_EnableSignOff``

0 commit comments

Comments
 (0)