From 18fc70bb734a42682937584f93ec84f65db8449c Mon Sep 17 00:00:00 2001
From: Nithin Muthukumar <kathrikai30201094@gmail.com>
Date: Mon, 29 May 2023 20:30:39 -0400
Subject: [PATCH 1/2] Working on insert in completion

---
 shrs_line/src/line.rs | 91 +++++++++++++++++++++++--------------------
 1 file changed, 49 insertions(+), 42 deletions(-)

diff --git a/shrs_line/src/line.rs b/shrs_line/src/line.rs
index c907b7fc..2f42265f 100644
--- a/shrs_line/src/line.rs
+++ b/shrs_line/src/line.rs
@@ -240,23 +240,21 @@ impl Line {
                     }
                 }
 
+                let should_break = self.handle_standard_keys(line_ctx, event.clone())?;
+                if should_break {
+                    break;
+                }
+
                 // handle menu events
                 if self.menu.is_active() {
                     self.handle_menu_keys(line_ctx, event.clone())?;
                 } else {
-                    // TODO bit hacky bubbling up control flow from funtion
                     match line_ctx.mode {
                         LineMode::Insert => {
-                            let should_break = self.handle_insert_keys(line_ctx, event)?;
-                            if should_break {
-                                break;
-                            }
+                            self.handle_insert_keys(line_ctx, event)?;
                         },
                         LineMode::Normal => {
-                            let should_break = self.handle_normal_keys(line_ctx, event)?;
-                            if should_break {
-                                break;
-                            }
+                            self.handle_normal_keys(line_ctx, event)?;
                         },
                     }
                 }
@@ -339,7 +337,14 @@ impl Line {
             }) => {
                 self.menu.next();
             },
-            _ => {},
+            _ => match ctx.mode {
+                LineMode::Insert => {
+                    self.handle_insert_keys(ctx, event)?;
+                },
+                LineMode::Normal => {
+                    self.handle_normal_keys(ctx, event)?;
+                },
+            },
         };
         Ok(())
     }
@@ -422,8 +427,8 @@ impl Line {
 
         res
     }
-
-    fn handle_insert_keys(&mut self, ctx: &mut LineCtx, event: Event) -> anyhow::Result<bool> {
+    //Keys that are universal regardless of mode, ex. Enter, Ctrl-c
+    fn handle_standard_keys(&mut self, ctx: &mut LineCtx, event: Event) -> anyhow::Result<bool> {
         match event {
             Event::Key(KeyEvent {
                 code: KeyCode::Enter,
@@ -435,6 +440,9 @@ impl Line {
                 modifiers: KeyModifiers::CONTROL,
                 ..
             }) => {
+                if self.menu.is_active() {
+                    return Ok(false);
+                }
                 self.buffer_history.clear();
                 self.painter.newline()?;
 
@@ -448,6 +456,32 @@ impl Line {
 
                 return Ok(true);
             },
+            Event::Key(KeyEvent {
+                code: KeyCode::Char('d'),
+                modifiers: KeyModifiers::CONTROL,
+                ..
+            }) => {
+                // if current input is empty exit the shell, otherwise treat it as enter
+                if ctx.cb.len() == 0 {
+                    // TODO maybe unify exiting the shell
+                    disable_raw_mode(); // TODO this is temp fix, should be more graceful way of
+                                        // handling cleanup code
+                    std::process::exit(0);
+                } else {
+                    self.buffer_history.clear();
+                    self.painter.newline()?;
+                    return Ok(true);
+                }
+            },
+
+            _ => (),
+        };
+
+        Ok(false)
+    }
+
+    fn handle_insert_keys(&mut self, ctx: &mut LineCtx, event: Event) -> anyhow::Result<()> {
+        match event {
             Event::Key(KeyEvent {
                 code: KeyCode::Tab,
                 modifiers: KeyModifiers::NONE,
@@ -527,23 +561,6 @@ impl Line {
                 }
             },
 
-            Event::Key(KeyEvent {
-                code: KeyCode::Char('d'),
-                modifiers: KeyModifiers::CONTROL,
-                ..
-            }) => {
-                // if current input is empty exit the shell, otherwise treat it as enter
-                if ctx.cb.len() == 0 {
-                    // TODO maybe unify exiting the shell
-                    disable_raw_mode(); // TODO this is temp fix, should be more graceful way of
-                                        // handling cleanup code
-                    std::process::exit(0);
-                } else {
-                    self.buffer_history.clear();
-                    self.painter.newline()?;
-                    return Ok(true);
-                }
-            },
             Event::Key(KeyEvent {
                 code: KeyCode::Char(c),
                 ..
@@ -552,22 +569,12 @@ impl Line {
             },
             _ => {},
         };
-        Ok(false)
+        Ok(())
     }
 
-    fn handle_normal_keys(&mut self, ctx: &mut LineCtx, event: Event) -> anyhow::Result<bool> {
+    fn handle_normal_keys(&mut self, ctx: &mut LineCtx, event: Event) -> anyhow::Result<()> {
         // TODO write better system toString support key combinations
         match event {
-            Event::Key(KeyEvent {
-                code: KeyCode::Enter,
-                modifiers: KeyModifiers::NONE,
-                ..
-            }) => {
-                self.buffer_history.clear();
-
-                self.painter.newline()?;
-                return Ok(true);
-            },
             Event::Key(KeyEvent {
                 code: KeyCode::Esc, ..
             }) => {
@@ -609,7 +616,7 @@ impl Line {
             },
             _ => {},
         }
-        Ok(false)
+        Ok(())
     }
 
     // recalculate the current completions

From fc785b41da17009d9aeab26c7d376dfae13b8492 Mon Sep 17 00:00:00 2001
From: Nithin Muthukumar <kathrikai30201094@gmail.com>
Date: Wed, 31 May 2023 22:26:49 -0400
Subject: [PATCH 2/2] temporarily disabling menu

---
 shrs_line/src/line.rs | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/shrs_line/src/line.rs b/shrs_line/src/line.rs
index 2f42265f..59f776f3 100644
--- a/shrs_line/src/line.rs
+++ b/shrs_line/src/line.rs
@@ -337,13 +337,16 @@ impl Line {
             }) => {
                 self.menu.next();
             },
-            _ => match ctx.mode {
-                LineMode::Insert => {
-                    self.handle_insert_keys(ctx, event)?;
-                },
-                LineMode::Normal => {
-                    self.handle_normal_keys(ctx, event)?;
-                },
+            _ => {
+                self.menu.disactivate();
+                match ctx.mode {
+                    LineMode::Insert => {
+                        self.handle_insert_keys(ctx, event)?;
+                    },
+                    LineMode::Normal => {
+                        self.handle_normal_keys(ctx, event)?;
+                    },
+                };
             },
         };
         Ok(())