Skip to content

Commit cf734f4

Browse files
update deps
1 parent de9465c commit cf734f4

File tree

3 files changed

+37
-45
lines changed

3 files changed

+37
-45
lines changed

pnpm-lock.yaml

+32-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ui/react-example/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
"@git-diff-view/react": "workspace:*",
1616
"@git-diff-view/shiki": "workspace:*",
1717
"@git-diff-view/vue": "workspace:*",
18-
"@my-react/react": "0.3.2",
19-
"@my-react/react-dom": "0.3.2",
18+
"@my-react/react": "0.3.3",
19+
"@my-react/react-dom": "0.3.3",
2020
"lodash": "^4.17.21",
2121
"overlayscrollbars": "^2.10.0",
2222
"react": "^18.2.0",
@@ -25,8 +25,8 @@
2525
"vue": "^3.4.38"
2626
},
2727
"devDependencies": {
28-
"@my-react/react-refresh": "0.3.2",
29-
"@my-react/react-vite": "0.0.5",
28+
"@my-react/react-refresh": "0.3.3",
29+
"@my-react/react-vite": "0.0.6",
3030
"@types/lodash": "^4.17.7",
3131
"@types/react": "^18.2.79",
3232
"@types/react-dom": "^18.2.25",

ui/react-example/src/Example.tsx

+1-9
Original file line numberDiff line numberDiff line change
@@ -280,26 +280,18 @@ export function Example() {
280280

281281
useEffect(() => {
282282
if (diffFileInstance) {
283-
// mount react
284-
// console.log("mount react");
285283
reactApp.current = createRoot(reactRef.current!);
286284
reactApp.current?.render?.(reactElement);
287-
// const ele = reactRef.current;
288285

289286
if (vueRef.current) {
290-
// mount vue
291287
vueApp.current = createApp(vueElement);
292288
vueApp.current.mount(vueRef.current);
293289
}
294290

295291
return () => {
296292
vueApp.current?.unmount?.();
297293
// TODO! fix unmount
298-
// @ts-ignore
299-
// if (ele.__container__ && ele.__container__.isAppMounted) {
300-
// console.log('unmount react');
301-
// reactApp.current?.unmount?.();
302-
// }
294+
// reactApp.current?.unmount?.();
303295
};
304296
}
305297
}, [diffFileInstance, reactElement, vueElement, enableVUE]);

0 commit comments

Comments
 (0)