Merge pull request #111 from scott-wyatt/fix-ssr

fix: check if platform is browser in default view adapter to prevent error during server-side rendering,closes #110

Author: MrWolfZ

ngrx-forms-3.0.2.tgz

@@ -90,7 +90,7 @@ describe(NgrxDefaultViewAdapter.name, () => {
   it('should not set the ID of the element if the ID of the state does not change', () => {
     const renderer: Renderer2 = jasmine.createSpyObj('renderer', ['setProperty']);
     const nativeElement: any = {};
-    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any);
+    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any, 'browser');
     viewAdapter.ngrxFormControlState = { id: TEST_ID } as any;
     viewAdapter.ngAfterViewInit();
     expect(renderer.setProperty).toHaveBeenCalledTimes(1);
@@ -132,7 +132,7 @@ describe(NgrxDefaultViewAdapter.name, () => {
   it('should call the registered function when the value changes and is composing but composition is not supported', () => {
     const renderer: Renderer2 = jasmine.createSpyObj('renderer', ['setProperty']);
     const nativeElement: any = {};
-    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any, androidNavigator);
+    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any, 'browser', androidNavigator);
     viewAdapter.ngrxFormControlState = { id: TEST_ID } as any;
     const spy = jasmine.createSpy('fn');
     viewAdapter.setOnChangeCallback(spy);
@@ -158,7 +158,7 @@ describe(NgrxDefaultViewAdapter.name, () => {
   it('should not call the registered function on composition end if composition is not supported', () => {
     const renderer: Renderer2 = jasmine.createSpyObj('renderer', ['setProperty']);
     const nativeElement: any = {};
-    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any, androidNavigator);
+    viewAdapter = new NgrxDefaultViewAdapter(renderer, { nativeElement } as any, 'browser', androidNavigator);
     viewAdapter.ngrxFormControlState = { id: TEST_ID } as any;
     const spy = jasmine.createSpy('fn');
     viewAdapter.setOnChangeCallback(spy);
@@ -194,7 +194,7 @@ describe(NgrxDefaultViewAdapter.name, () => {
   });
 
   it('should not throw if calling callbacks before they are registered', () => {
-    expect(() => new NgrxDefaultViewAdapter(undefined as any, undefined as any).onChange(undefined)).not.toThrowError();
-    expect(() => new NgrxDefaultViewAdapter(undefined as any, undefined as any).onTouched()).not.toThrowError();
+    expect(() => new NgrxDefaultViewAdapter(undefined as any, undefined as any, undefined as any).onChange(undefined)).not.toThrowError();
+    expect(() => new NgrxDefaultViewAdapter(undefined as any, undefined as any, undefined as any).onTouched()).not.toThrowError();
   });
 });

src/view-adapter/default.spec.ts

@@ -1,4 +1,5 @@
-import { AfterViewInit, Directive, ElementRef, forwardRef, HostListener, Inject, Input, Optional, Renderer2 } from '@angular/core';
+import { isPlatformBrowser } from '@angular/common';
+import { AfterViewInit, Directive, ElementRef, forwardRef, HostListener, Inject, Input, Optional, PLATFORM_ID, Renderer2 } from '@angular/core';
 
 import { FormControlState } from '../state';
 import { FormViewAdapter, NGRX_FORM_VIEW_ADAPTER } from './view-adapter';
@@ -59,10 +60,11 @@ export class NgrxDefaultViewAdapter implements FormViewAdapter, AfterViewInit {
   constructor(
     private renderer: Renderer2,
     private elementRef: ElementRef,
+    @Optional() @Inject(PLATFORM_ID) private readonly platformId: string,
     // we use a special injection string that should never exist at runtime to allow mocking this dependency for testing
     @Optional() @Inject('ngrx-forms/never') navigator: Navigator | null = null,
   ) {
-    this.isCompositionSupported = !isAndroid(navigator || window.navigator);
+    this.isCompositionSupported = isPlatformBrowser(this.platformId) && !isAndroid(navigator || window.navigator);
   }
 
   ngAfterViewInit() {

src/view-adapter/default.ts

@@ -5,7 +5,7 @@ import { selectViewAdapter } from './util';
 
 describe(selectViewAdapter.name, () => {
   it('should return the default view adapter if it is the only provided', () => {
-    const viewAdapter = new NgrxDefaultViewAdapter(undefined as any, undefined as any);
+    const viewAdapter = new NgrxDefaultViewAdapter(undefined as any, undefined as any, undefined as any);
     const result = selectViewAdapter([viewAdapter]);
     expect(result).toBe(viewAdapter);
   });