fix: empty groups and arrays are now always enabled instead of disabled and therefore errors can now be set on empty groups and arrays

Author: MrWolfZ

CHANGELOG.md

@@ -1,7 +1,11 @@
 ## ngrx-forms Changelog
 
-<a name="2.1.3"></a>
-### 2.1.3
+<a name="2.2.0"></a>
+### 2.2.0
+
+#### Breaking Changes
+
+* empty groups and arrays are now always enabled instead of disabled and therefore errors can now be set on empty groups and arrays (note that this is only a minor breaking change and only applies in edge cases and therefore this fix is included in a new minor instead of a new major version), closes [#37](https://github.com/MrWolfZ/ngrx-forms/issues/37)
 
 #### Bugfixes
 

src/array/reducer/set-errors.spec.ts

@@ -46,15 +46,14 @@ describe(`form array ${setErrorsReducer.name}`, () => {
     expect(resultState).toBe(INITIAL_STATE);
   });
 
-  // will be fixed as part of another bugfix
-  // it('should update state if array is empty', () => {
-  //   const errors = { required: true };
-  //   const state = createFormArrayState<string>('test ID', []);
-  //   const resultState = setErrorsReducer(state, new SetErrorsAction(FORM_CONTROL_ID, errors));
-  //   expect(resultState.errors).toEqual(errors);
-  //   expect(resultState.isValid).toBe(false);
-  //   expect(resultState.isInvalid).toBe(true);
-  // });
+  it('should update state if array is empty', () => {
+    const errors = { required: true };
+    const state = createFormArrayState<string>('test ID', []);
+    const resultState = setErrorsReducer(state, new SetErrorsAction(FORM_CONTROL_ID, errors));
+    expect(resultState.errors).toEqual(errors);
+    expect(resultState.isValid).toBe(false);
+    expect(resultState.isInvalid).toBe(true);
+  });
 
   it('should keep async errors', () => {
     const syncErrors = { required: true };

src/group/reducer/set-errors.spec.ts

@@ -1,4 +1,5 @@
 import { SetErrorsAction } from '../../actions';
+import { createFormGroupState } from '../../state';
 import { setErrorsReducer } from './set-errors';
 import {
   FORM_CONTROL_ID,
@@ -47,6 +48,15 @@ describe(`form group ${setErrorsReducer.name}`, () => {
     expect(resultState).toBe(INITIAL_STATE);
   });
 
+  it('should update state if group is empty', () => {
+    const errors = { required: true };
+    const state = createFormGroupState('test ID', {});
+    const resultState = setErrorsReducer(state, new SetErrorsAction(FORM_CONTROL_ID, errors));
+    expect(resultState.errors).toEqual(errors);
+    expect(resultState.isValid).toBe(false);
+    expect(resultState.isInvalid).toBe(true);
+  });
+
   it('should keep async errors', () => {
     const syncErrors = { required: true };
     const asyncErrors = { $required: true };