proper logout

Author: MrZoidberg

api/api.go

@@ -62,6 +62,10 @@ func (a *Api) getSession(host string) *Session {
 	return session
 }
 
+func (a *Api) deleteSession(host string) {
+	delete(a.sessions, host)
+}
+
 func (a *Api) postRequest(host string, path string, data string) (*http.Response, error) {
 	// get session
 	session := a.getSession(host)

api/login.go

@@ -96,3 +96,53 @@ func (a *Api) Login(host string, user string, password string) (*Session, error)
 
 	return nil, &BMCAPIError{StatusCode: resp.StatusCode, Message: "failed to login"}
 }
+
+// Logout makes a request to the BMC to logout the user
+func (a *Api) Logout(host string) error {
+	/*
+		curl 'https://endor-bmc.lan/api/session' -X DELETE -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:128.0) Gecko/20100101 Firefox/128.0' -H 'Accept: application/json, text/javascript, */ /*; q=0.01' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate, br, zstd' -H 'Content-Type: application/x-www-form-urlencoded; charset=UTF-8' -H 'X-CSRFTOKEN: null' -H 'X-Requested-With: XMLHttpRequest' -H 'Origin: https://endor-bmc.lan' -H 'Connection: keep-alive' -H 'Referer: https://endor-bmc.lan/' -H 'Cookie: lang=en-us; i18next=en-us' -H 'Sec-Fetch-Dest: empty' -H 'Sec-Fetch-Mode: cors' -H 'Sec-Fetch-Site: same-origin' -H 'Priority: u=0' --data-raw ''
+	 */
+
+	// get session
+	session := a.getSession(host)
+	if session == nil {
+		return &NoSessionError{"no session found"}
+	}
+
+	// call api
+	var domain string
+	if a.options.UseSsl {
+		domain = "https://" + host
+	} else {
+		domain = "http://" + host
+	}
+	resource := "/api/session"
+
+	u, _ := url.ParseRequestURI(domain)
+	u.Path = resource
+	urlStr := u.String()
+
+	r, err := http.NewRequest(http.MethodDelete, urlStr, nil)
+	r.Header.Add("X-CSRFTOKEN", session.CSRFToken)
+	r.Header.Add("Cookie", "QSESSIONID="+session.QSessionID)
+
+	if err != nil {
+		return fmt.Errorf("failed to logout: %v", err)
+	}
+
+	resp, err := a.httpClient.Do(r)
+	if err != nil {
+		return fmt.Errorf("failed to logout: %v", err)
+	}
+
+	defer resp.Body.Close()
+	switch resp.StatusCode {
+	case 200:
+		// success
+		// remove session from cache
+		a.deleteSession(host)
+		return nil
+	}
+
+	return &BMCAPIError{StatusCode: resp.StatusCode, Message: "failed to logout"}
+}

cmd/power.go

@@ -29,6 +29,13 @@ func PowerOn(c *cli.Context) error {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to login to BMC host %s: %v", profile.Host, err), 1)
 	}
 
+	defer func() {
+		err = srv.Logout(profile.Host)
+		if err != nil {
+			lgr.Logger.Logf("[WARN] Failed to logout from BMC host %s: %v", profile.Host, err)
+		}
+	}()
+
 	err = srv.PowerOn(profile.Host)
 	if err != nil {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to power on BMC host %s: %v", profile.Host, err), 1)
@@ -74,6 +81,13 @@ func PowerOff(c *cli.Context) error {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to login to BMC host %s: %v", profile.Host, err), 1)
 	}
 
+	defer func() {
+		err = srv.Logout(profile.Host)
+		if err != nil {
+			lgr.Logger.Logf("[WARN] Failed to logout from BMC host %s: %v", profile.Host, err)
+		}
+	}()
+
 	err = srv.PowerOff(profile.Host)
 	if err != nil {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to power off BMC host %s: %v", profile.Host, err), 1)
@@ -119,6 +133,13 @@ func PowerStatus(c *cli.Context) error {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to login to BMC host %s: %v", profile.Host, err), 1)
 	}
 
+	defer func() {
+		err = srv.Logout(profile.Host)
+		if err != nil {
+			lgr.Logger.Logf("[WARN] Failed to logout from BMC host %s: %v", profile.Host, err)
+		}
+	}()
+
 	status, err := srv.ChassisStatus(profile.Host)
 	if err != nil {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to get power status for BMC host %s: %v", profile.Host, err), 1)

cmd/sensor.go

@@ -41,6 +41,13 @@ func SensorList(c *cli.Context) error {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to login to BMC host %s: %v", profile.Host, err), 1)
 	}
 
+	defer func() {
+		err = srv.Logout(profile.Host)
+		if err != nil {
+			lgr.Logger.Logf("[WARN] Failed to logout from BMC host %s: %v", profile.Host, err)
+		}
+	}()
+
 	sensors, err := srv.GetSensorsList(profile.Host)
 	if err != nil {
 		return cli.Exit(fmt.Sprintf("FAIL: Failed to get sensor list from BMC host %s: %v", profile.Host, err), 1)