Skip to content

Commit 0f17dc1

Browse files
ThorneANNMrart
authored andcommitted
[Minor][FLINK-39168][cdc-connector-mysql] Cache split.splitId() result in a local variable to avoid calling the method twice per iteration: (apache#4288)
Co-authored-by: Thorne <syyfffy@163.com>
1 parent 4da0c6a commit 0f17dc1

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,11 +390,12 @@ public List<FinishedSnapshotSplitInfo> getFinishedSplitInfos() {
390390
new ArrayList<>(assignedSplits.values());
391391
List<FinishedSnapshotSplitInfo> finishedSnapshotSplitInfos = new ArrayList<>();
392392
for (MySqlSchemalessSnapshotSplit split : assignedSnapshotSplit) {
393-
BinlogOffset binlogOffset = splitFinishedOffsets.get(split.splitId());
393+
String splitId = split.splitId();
394+
BinlogOffset binlogOffset = splitFinishedOffsets.get(splitId);
394395
finishedSnapshotSplitInfos.add(
395396
new FinishedSnapshotSplitInfo(
396397
split.getTableId(),
397-
split.splitId(),
398+
splitId,
398399
split.getSplitStart(),
399400
split.getSplitEnd(),
400401
binlogOffset));

0 commit comments

Comments
 (0)