fix(store/stremthru): fix double nzb for own newznab nzb link

Author: MunifTanjim

internal/endpoint/newznab.go

@@ -58,7 +58,7 @@ func handleNewznab(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	baseURL := shared.ExtractRequestBaseURL(r).JoinPath("/v0/newznab")
+	baseURL := config.BaseURL.JoinPath("/v0/newznab")
 
 	switch t {
 	case "search", "tvsearch", "movie":
@@ -165,7 +165,7 @@ func handleNewznabByIndexer(w http.ResponseWriter, r *http.Request) {
 			sendZnabResponse(w, r, 200, znab.ErrorUnknownError(err.Error()), o)
 			return
 		}
-		baseURL := shared.ExtractRequestBaseURL(r).JoinPath("/v0/newznab")
+		baseURL := config.BaseURL.JoinPath("/v0/newznab")
 		nzbLinkQuery := url.Values{
 			"apikey": {r.URL.Query().Get("apikey")},
 			"t":      {"get"},
@@ -201,7 +201,7 @@ func handleNewznabGet(w http.ResponseWriter, r *http.Request, o string) {
 		return
 	}
 
-	indexerId, link, err := newznab.StremThruIndexer.UnwrapLink(nzbId)
+	indexerId, link, err := newznab.StremThruIndexer.UnwrapLink(nzbId, true)
 	if err != nil {
 		sendZnabResponse(w, r, 200, znab.ErrorIncorrectParameter("invalid id"), o)
 		return

internal/newznab/indexer.go

@@ -286,7 +286,7 @@ func parseNZBId(nzbId string) (indexerId int64, downloadURL string, err error) {
 	return indexerId, downloadURL, nil
 }
 
-func (sti stremThruIndexer) UnwrapLink(id string) (int64, *url.URL, error) {
+func (sti stremThruIndexer) UnwrapLink(id string, checkRateLimit bool) (int64, *url.URL, error) {
 	indexerId, link, err := parseNZBId(id)
 	if err != nil {
 		return 0, nil, err
@@ -300,16 +300,18 @@ func (sti stremThruIndexer) UnwrapLink(id string) (int64, *url.URL, error) {
 		return indexerId, nil, errors.New("indexer not found")
 	}
 
-	rl, err := indexer.GetRateLimiter()
-	if err != nil {
-		return indexerId, nil, err
-	}
-	if rl != nil {
-		if result, err := rl.Try(); err != nil {
+	if checkRateLimit {
+		rl, err := indexer.GetRateLimiter()
+		if err != nil {
 			return indexerId, nil, err
-		} else if !result.Allowed {
-			newznab_stats.RecordRateLimited(indexerId, newznab_stats.OperationDownload)
-			return indexerId, nil, errors.New("rate limit exceeded")
+		}
+		if rl != nil {
+			if result, err := rl.Try(); err != nil {
+				return indexerId, nil, err
+			} else if !result.Allowed {
+				newznab_stats.RecordRateLimited(indexerId, newznab_stats.OperationDownload)
+				return indexerId, nil, errors.New("rate limit exceeded")
+			}
 		}
 	}
 

store/stremthru/store.go

@@ -3,6 +3,7 @@ package stremthru
 import (
 	"errors"
 	"net/http"
+	"net/url"
 	"path/filepath"
 	"strings"
 	"time"
@@ -11,6 +12,7 @@ import (
 	"github.com/MunifTanjim/stremthru/internal/cache"
 	"github.com/MunifTanjim/stremthru/internal/config"
 	"github.com/MunifTanjim/stremthru/internal/job/job_queue"
+	"github.com/MunifTanjim/stremthru/internal/newznab"
 	usenetmanager "github.com/MunifTanjim/stremthru/internal/usenet/manager"
 	"github.com/MunifTanjim/stremthru/internal/usenet/nzb_info"
 	usenet_pool "github.com/MunifTanjim/stremthru/internal/usenet/pool"
@@ -148,7 +150,27 @@ func (c *StoreClient) AddNewz(params *store.AddNewzParams) (*store.AddNewzData,
 		return nil, err
 	}
 
-	id, err := nzb_info.QueueJob(ba.Username, "", params.Link, "", 0, "", 0)
+	link, indexerId := params.Link, int64(0)
+
+	if u, err := url.Parse(link); err != nil {
+		err := core.NewStoreError("invalid link").WithCause(err)
+		err.StoreName = string(store.StoreNameStremThru)
+		err.StatusCode = http.StatusBadRequest
+		return nil, err
+	} else if u.Host == config.BaseURL.Host {
+		nzbId := u.Query().Get("id")
+		if nzbIndexerId, nzbLink, err := newznab.StremThruIndexer.UnwrapLink(nzbId, false); err != nil {
+			err := core.NewStoreError("invalid link").WithCause(err)
+			err.StoreName = string(store.StoreNameStremThru)
+			err.StatusCode = http.StatusBadRequest
+			return nil, err
+		} else {
+			link = nzbLink.String()
+			indexerId = nzbIndexerId
+		}
+	}
+
+	id, err := nzb_info.QueueJob(ba.Username, "", link, "", 0, "", indexerId)
 	if err != nil {
 		return nil, err
 	}