Skip to content

Commit 865c926

Browse files
authored
Merge pull request #554 from MurhafSousli/dev
Upgrade to Angular 12
2 parents c4fb1e4 + 7601ad4 commit 865c926

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+7537
-7869
lines changed
Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,31 @@
11
---
2-
name: Bug report
3-
about: Create a report to help us improve
4-
2+
name: Bug Report
3+
about: Report a bug found in ngx-sharebuttons
54
---
65

7-
<!--
8-
1. Please make sure that you have searched in the older issues before submitting a new one!
9-
2. Please fill out all the required information!
10-
-->
11-
12-
#### I am submitting a
13-
14-
- [x] Bug Report
15-
16-
#### What is the expected behavior?
17-
186

19-
#### What is the current behavior?
7+
#### Reproduction
208

9+
Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/ngx-sharebuttons
2110

22-
#### What are the steps to reproduce?
11+
Steps to reproduce:
12+
1.
13+
2.
2314

24-
<!--
25-
Providing a StackBlitz reproduction is the *best* way to share your issue. <br/>
26-
StackBlitz starter: https://stackblitz.com/edit/ngx-sharebuttons<br/>
27-
-->
2815

16+
#### Expected Behavior
2917

30-
#### What is the use-case or motivation for changing an existing behavior?
18+
What behavior were you expecting to see?
3119

3220

21+
#### Actual Behavior
3322

34-
#### Which versions are you using for the following packages?
23+
What behavior did you actually see?
3524

36-
Angular:
37-
Angular CDK:
38-
Angular CLI:
39-
Angular-fontawesome:
40-
ngx-sharebuttons:
4125

26+
#### Environment
4227

43-
#### Is there anything else we should know?
28+
- Angular:
29+
- ngx-sharebuttons:
30+
- Browser(s):
31+
- Operating System (e.g. Windows, macOS, Ubuntu):
Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,13 @@
11
---
2-
name: Feature request
3-
about: Suggest an idea for this project
4-
2+
name: Feature
3+
about: Propose a new feature for ngx-sharebuttons
4+
labels: feature
55
---
66

7-
<!--
8-
1. Please make sure that you have searched in the older issues before submitting a new one!
9-
2. Please fill out all the required information!
10-
-->
11-
12-
#### I am submitting a
13-
14-
- [x] Feature Request
15-
16-
#### Description
17-
18-
19-
20-
#### What is the use-case or motivation for the new feature?
21-
22-
23-
24-
#### Which versions are you using for the following packages?
7+
#### Feature Description
258

26-
ngx-sharebuttons:
9+
Provide a brief summary of the feature you would like to see.
2710

11+
#### Use Case
2812

29-
#### Is there anything else we should know?
13+
Describe the use case(s) that the proposed feature would enable.

.github/ISSUE_TEMPLATE/question.md

Lines changed: 0 additions & 28 deletions
This file was deleted.

.github/workflows/integrate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
with:
1717
node-version: 14
1818
- name: Install dependencies
19-
run: npm install
19+
run: npm ci
2020
- name: Build
2121
run: npm run build-lib
2222
- name: Test

.github/workflows/netlify.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ jobs:
1414
with:
1515
node-version: 14
1616
- name: Install dependencies
17-
run: npm install
18-
- name: Build and link library
19-
run: npm run build-lib && npm run link-lib
17+
run: npm ci
18+
- name: Build library
19+
run: npm run build-lib
2020
- name: Build demo
2121
run: npm run build-demo
2222
- name: Deploy to Netlify

CHANGELOG.MD

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 8.1.0
4+
5+
- Upgrade to Angular 12
6+
- feat(buttons): Add aria-label to the expand button, closes [#546](https://github.com/MurhafSousli/ngx-sharebuttons/issues/546) in [73c5aef](https://github.com/MurhafSousli/ngx-sharebuttons/commit/73c5aef15c373795bf99f6e841ad744ad4478813).
7+
- fix(build): Fix package to work with ivy, closes [#523](https://github.com/MurhafSousli/ngx-sharebuttons/issues/523) in [096d62a](https://github.com/MurhafSousli/ngx-sharebuttons/commit/096d62aff0aa9c8d6c9bb54561b713378bdd0081).
8+
39
## 8.0.5
410

511
- Upgrade to Angular 11

angular.json

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"projectType": "library",
88
"root": "projects/ngx-sharebuttons",
99
"sourceRoot": "projects/ngx-sharebuttons/src",
10-
"prefix": "lib",
10+
"prefix": "",
1111
"architect": {
1212
"build": {
1313
"builder": "@angular-devkit/build-angular:ng-packagr",
@@ -62,7 +62,6 @@
6262
"main": "projects/ngx-sharebuttons-demo/src/main.ts",
6363
"polyfills": "projects/ngx-sharebuttons-demo/src/polyfills.ts",
6464
"tsConfig": "projects/ngx-sharebuttons-demo/tsconfig.app.json",
65-
"aot": true,
6665
"assets": [
6766
"projects/ngx-sharebuttons-demo/src/favicon.ico",
6867
"projects/ngx-sharebuttons-demo/src/assets"
@@ -73,7 +72,13 @@
7372
"scripts": [],
7473
"allowedCommonJsDependencies": [
7574
"highlight.js"
76-
]
75+
],
76+
"vendorChunk": true,
77+
"extractLicenses": false,
78+
"buildOptimizer": false,
79+
"sourceMap": true,
80+
"optimization": false,
81+
"namedChunks": true
7782
},
7883
"configurations": {
7984
"production": {
@@ -103,7 +108,8 @@
103108
}
104109
]
105110
}
106-
}
111+
},
112+
"defaultConfiguration": ""
107113
},
108114
"serve": {
109115
"builder": "@angular-devkit/build-angular:dev-server",
@@ -169,7 +175,9 @@
169175
"options": {
170176
"outputPath": "dist/ngx-sharebuttons-demo/server",
171177
"main": "projects/ngx-sharebuttons-demo/server.ts",
172-
"tsConfig": "projects/ngx-sharebuttons-demo/tsconfig.server.json"
178+
"tsConfig": "projects/ngx-sharebuttons-demo/tsconfig.server.json",
179+
"sourceMap": true,
180+
"optimization": false
173181
},
174182
"configurations": {
175183
"production": {
@@ -183,7 +191,8 @@
183191
"sourceMap": false,
184192
"optimization": true
185193
}
186-
}
194+
},
195+
"defaultConfiguration": ""
187196
},
188197
"serve-ssr": {
189198
"builder": "@nguniversal/builders:ssr-dev-server",

karma.conf.js

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,28 @@ module.exports = function (config) {
99
require('karma-jasmine'),
1010
require('karma-chrome-launcher'),
1111
require('karma-jasmine-html-reporter'),
12-
require('karma-coverage-istanbul-reporter'),
12+
require('karma-coverage'),
1313
require('@angular-devkit/build-angular/plugins/karma')
1414
],
1515
client: {
16+
jasmine: {
17+
// you can add configuration options for Jasmine here
18+
// the possible options are listed at https://jasmine.github.io/api/edge/Configuration.html
19+
// for example, you can disable the random execution with `random: false`
20+
// or set a specific seed with `seed: 4321`
21+
},
1622
clearContext: false // leave Jasmine Spec Runner output visible in browser
1723
},
18-
coverageIstanbulReporter: {
19-
dir: require('path').join(__dirname, './coverage/ngx-sharebuttons'),
20-
reports: ['html', 'lcovonly', 'text-summary'],
21-
fixWebpackSourcePaths: true
24+
jasmineHtmlReporter: {
25+
suppressAll: true // removes the duplicated traces
26+
},
27+
coverageReporter: {
28+
dir: require('path').join(__dirname, './coverage/test-app'),
29+
subdir: '.',
30+
reporters: [
31+
{ type: 'html' },
32+
{ type: 'text-summary' }
33+
]
2234
},
2335
reporters: ['progress', 'kjhtml'],
2436
port: 9876,

0 commit comments

Comments
 (0)