Skip to content

Commit d8c3365

Browse files
authored
Merge pull request #702 from MurhafSousli/release/15.0.6
v15.0.6
2 parents dd1641e + 90865a3 commit d8c3365

File tree

6 files changed

+11
-9
lines changed

6 files changed

+11
-9
lines changed

CHANGELOG.MD

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
# Changelog
22

3-
## 15.0.4
3+
## 15.0.6
44

55
- Add link in message body even if description was not provided, closes [#697](https://github.com/MurhafSousli/ngx-sharebuttons/issues/697) and [#610](https://github.com/MurhafSousli/ngx-sharebuttons/issues/610).
66
- Remove FontAwesome type imports from the share directive, closes [#673](https://github.com/MurhafSousli/ngx-sharebuttons/issues/673).
77
- Refactor all inputs to signal inputs.
88

9+
## 15.0.4 and 15.0.5 are faulty releases
10+
911
## 15.0.3
1012

1113
- enhance: enhance: Use injection factory for `SHARE_BUTTONS_CONFIG` and `SHARE_BUTTONS_PROP` to avoid merging custom options with the default options for every share button.

projects/ngx-sharebuttons-demo/src/app/pages/home/home.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ <h3>Share Buttons</h3>
1414
</a>
1515
</div>
1616
<div class="sb-option">
17-
<a mat-raised-button routerLink="/share-buttons-component">
17+
<a mat-raised-button routerLink="/share-button-component">
1818
<img src="assets/img/sharebutton-component.svg"/>
1919
<h3>Single Share Button</h3>
2020
</a>

projects/ngx-sharebuttons-demo/src/app/shared/overview-content/overview-content.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export class OverviewContentComponent implements OnInit, AfterViewInit, OnDestro
5252
private fragmentSub$: Subscription;
5353

5454
ngOnInit(): void {
55-
this.links = Array.from(this.scrollbar.viewport.nativeElement.querySelectorAll('h2'));
55+
this.links = Array.from(this.scrollbar.nativeElement.querySelectorAll('h2'));
5656
setTimeout(() => {
5757
this.activeLinkId.set(this.links[0].id);
5858
});

projects/ngx-sharebuttons-demo/src/app/shared/section-title/section-title.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, SkipSelf, ChangeDetectionStrategy } from '@angular/core';
1+
import { Component, inject, ChangeDetectionStrategy } from '@angular/core';
22
import { RouterLink } from '@angular/router';
33
import { NgScrollbar } from 'ngx-scrollbar';
44
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
@@ -31,8 +31,8 @@ import { KebabCasePipe } from '../kebab-case.pipe';
3131
})
3232
export class SectionTitleComponent {
3333

34-
iconCaretRight: IconDefinition = faCaretRight;
34+
readonly iconCaretRight: IconDefinition = faCaretRight;
35+
36+
readonly scrollbar: NgScrollbar = inject(NgScrollbar);
3537

36-
constructor(@SkipSelf() public scrollbar: NgScrollbar) {
37-
}
3838
}

projects/ngx-sharebuttons/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ngx-sharebuttons",
3-
"version": "15.0.4",
3+
"version": "15.0.6",
44
"license": "MIT",
55
"homepage": "https://ngx-sharebuttons.netlify.app/",
66
"author": {

projects/ngx-sharebuttons/src/lib/share.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export class ShareService {
103103

104104
return Object.entries(shareButton.params).reduce((params: Record<string, string>, [key, realKey]: [string, string]) => {
105105
// Check if param has a value
106-
if (shareButton.requiredParams[key] || computedParams[key]) {
106+
if ((shareButton.requiredParams && shareButton.requiredParams[key]) || computedParams[key]) {
107107
// Check if param has a resolver function
108108
const resolver: ShareParamsFunc = shareButton.paramsFunc?.[key];
109109
params[realKey] = resolver ? resolver(computedParams) : computedParams[key];

0 commit comments

Comments
 (0)