-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Description
I think this is a good example of where maybe splitting the analyzers into two can help.
The ShowSkyWithoutRegion test only fails because ShowSkyAnalyzer was upgraded to a contextual analyzer. But it was only upgraded because a new topic was added that required it be contextual
This causes two problems:
- Makes testing more complicated (we dont have good contextual tests atm)
- For now makes us hide this test
- Potentially keeps topic 391 from running at all, if it were to be an isolated analyzer run
I think we can split ShowSkyAnalyzer into an isolated one and a contextual one. This will let us resurrect the test, AND let topic 391 run on a non-contextual run
Metadata
Metadata
Assignees
Labels
No labels