MCR-3642 do not require required instances for implicit classes in collections

Author: toKrause

mycore-base/src/main/java/org/mycore/common/config/MCRConfigurableInstanceHelper.java

@@ -851,8 +851,8 @@ private static abstract class Source<A extends Annotation, V> {
 
         public abstract V get(MCRInstanceConfiguration configuration, Target<?> target);
 
-        public final Set<Option> createOptions(Class<?> valueClass, boolean required) {
-            return required && Modifier.isFinal(valueClass.getModifiers())
+        public final Set<Option> createOptions(Class<?> valueClass) {
+            return Modifier.isFinal(valueClass.getModifiers())
                 ? ADD_IMPLICIT_CLASS_PROPERTIES : NO_OPTIONS;
         }
 
@@ -1366,7 +1366,7 @@ public Object get(MCRInstanceConfiguration configuration, Target<?> target) {
                 }
             }
 
-            Set<Option> options = createOptions(annotation.valueClass(), annotation.required());
+            Set<Option> options = createOptions(annotation.valueClass());
             Object instance = getInstance(annotation.valueClass(), nestedConfiguration, options);
 
             if (!annotation.valueClass().isAssignableFrom(instance.getClass())) {
@@ -1443,7 +1443,7 @@ public Map<String, Object> get(MCRInstanceConfiguration configuration, Target<?>
                     + getExampleName(configuration, "B") + ", ...");
             }
 
-            Set<Option> options = createOptions(annotation.valueClass(), annotation.required());
+            Set<Option> options = createOptions(annotation.valueClass());
             Map<String, Object> instanceMap = nestedConfigurationMap.entrySet().stream()
                 .collect(Collectors.toMap(Map.Entry::getKey,
                     entry -> getInstance(annotation.valueClass(), entry.getValue(), options)));
@@ -1539,7 +1539,7 @@ public List<Object> get(MCRInstanceConfiguration configuration, Target<?> target
                     + getExampleName(configuration, "2") + ", ...");
             }
 
-            Set<Option> options = createOptions(annotation.valueClass(), annotation.required());
+            Set<Option> options = createOptions(annotation.valueClass());
             List<Object> instanceList = nestedConfigurationList.stream()
                 .map(c -> (Object) getInstance(annotation.valueClass(), c, options)).toList();