-
Notifications
You must be signed in to change notification settings - Fork 13
Process Pull Request
Thomas Scheffler edited this page Oct 21, 2016
·
2 revisions
- check if pull request is made for the correct target branch (look at Jira Ticket), else close the pull request
- check if commit author is clickable and matches a GitHub account
- check if commit message format is correct (MCR-0000 TicketDescription CommitDescription)
- check if not to many simple commits are made, let them squash then before merge
- wait for Travis CI to give green, sometimes a restart of the test build can make it green
If any check above is missing let the request open and the author fix it first.
- in case of LTS merge to master make a merge commit, IN ALL OTHER CASES: REBASE AND MERGE