[CLEANUP] Reduce callbacks for data providers in the tests (#1403)

Let's reduce cognitive complexity to make the lives of the
poor developers a bit easier.

This is in preparation to migrating more data providers to
the new `rawr/phpunit-data-provider` package.

Author: oliverklee

config/phpstan-baseline.neon

@@ -242,24 +242,6 @@ parameters:
 			count: 1
 			path: ../tests/Unit/HtmlProcessor/HtmlPrunerTest.php
 
-		-
-			message: '#^Method Pelago\\Emogrifier\\Tests\\Unit\\Support\\Constraint\\IsEquivalentCssTest\:\:arrayMapKeys\(\) should return array\<string, T\> but returns array\<string, T\>\|false\.$#'
-			identifier: return.type
-			count: 1
-			path: ../tests/Unit/Support/Constraint/IsEquivalentCssTest.php
-
-		-
-			message: '#^Method Pelago\\Emogrifier\\Tests\\Unit\\Support\\Constraint\\StringContainsCssCountTest\:\:arrayMapKeys\(\) should return array\<string, T\> but returns array\<string, T\>\|false\.$#'
-			identifier: return.type
-			count: 1
-			path: ../tests/Unit/Support/Constraint/StringContainsCssCountTest.php
-
-		-
-			message: '#^Method Pelago\\Emogrifier\\Tests\\Unit\\Support\\Constraint\\StringContainsCssTest\:\:arrayMapKeys\(\) should return array\<string, T\> but returns array\<string, T\>\|false\.$#'
-			identifier: return.type
-			count: 1
-			path: ../tests/Unit/Support/Constraint/StringContainsCssTest.php
-
 		-
 			message: '#^Parameter \#1 \$input of function array_filter expects array, array\<int, array\<int, string\>\>\|null given\.$#'
 			identifier: argument.type

tests/Support/Traits/CssDataProviders.php

@@ -143,12 +143,10 @@ public function provideEquivalentCssInStyleTags(): array
     {
         $datasetsWithoutStyleTags = $this->provideEquivalentCompleteCss();
 
-        $datasetsWithRenamedKeys = static::arrayMapKeys(
-            static function (string $description): string {
-                return $description . ' in <style> tag';
-            },
-            $datasetsWithoutStyleTags
-        );
+        $datasetsWithRenamedKeys = [];
+        foreach ($datasetsWithoutStyleTags as $description => $dataset) {
+            $datasetsWithRenamedKeys[$description . ' in <style> tag'] = $dataset;
+        }
 
         $datasets = \array_map(
             /**
@@ -346,17 +344,4 @@ private static function crossDatasetWithItself(array $dataset): array
 
         return $result;
     }
-
-    /**
-     * @template T
-     *
-     * @param callable(string):string $callback
-     * @param array<string, T> $array
-     *
-     * @return array<string, T>
-     */
-    private static function arrayMapKeys(callable $callback, array $array): array
-    {
-        return \array_combine(\array_map($callback, \array_keys($array)), \array_values($array));
-    }
 }

tests/Unit/Support/Constraint/IsEquivalentCssTest.php

@@ -59,22 +59,10 @@ public function provideNonEquivalentCss(): array
     {
         $datasets = $this->provideCssNeedleNotFoundInHaystack() + $this->provideCssNeedleFoundInLargerHaystack();
 
-        $transposedDatasets = \array_map(
-            /**
-             * @param array{0: string, 1: string} $dataset
-             *
-             * @return array{0: string, 1: string}
-             */
-            static function (array $dataset): array {
-                return [$dataset[1], $dataset[0]];
-            },
-            static::arrayMapKeys(
-                static function (string $description): string {
-                    return $description . ' (transposed)';
-                },
-                $datasets
-            )
-        );
+        $transposedDatasets = [];
+        foreach ($datasets as $description => $dataset) {
+            $transposedDatasets[$description . ' (transposed)'] = [$dataset[1], $dataset[0]];
+        }
 
         return $datasets + $transposedDatasets;
     }