I just noticed that we're setting the enclosure.platform config to mycroft_mark_2 on install.
Is that to get around people using if platform == "mycroft_mark_2" in Skills etc, when they want to check if a GUI is connected? Or are there other reasons a dev environment should pretend to be a Mark 2?
I can certainly see having a "Mark II" mode being useful - to try and emulate a Mark II setup as much as possible - config, correct dimensions, etc. But I'm wondering if that should be an intentional option rather than the default config?
It jumped out at me because if we are writing to a mycroft.conf file we'll need to switch to the XDG path for it instead of the hard coded value.
Any thoughts or preferences?
I just noticed that we're setting the
enclosure.platformconfig tomycroft_mark_2on install.Is that to get around people using
if platform == "mycroft_mark_2"in Skills etc, when they want to check if a GUI is connected? Or are there other reasons a dev environment should pretend to be a Mark 2?I can certainly see having a "Mark II" mode being useful - to try and emulate a Mark II setup as much as possible - config, correct dimensions, etc. But I'm wondering if that should be an intentional option rather than the default config?
It jumped out at me because if we are writing to a
mycroft.conffile we'll need to switch to the XDG path for it instead of the hard coded value.Any thoughts or preferences?