`zebra-init` is called repeatedly for each code block

[ensko]

When trying to override some zebraw settings, I noticed the following lines:

shiroa/packages/shiroa/templates.typ

Lines 234 to 245 in fda1a7d

	/// HTML code block supported by zebraw.
	show: init-with-theme(default-theme)
	set raw(tab-size: 114)
	let in-mk-raw = state("shiroa:in-mk-raw", false)
	let mk-raw(
	it,
	tag: "div",
	inline: false,
	) = {
	theme-box(tag: tag, theme => {
	show: init-with-theme(theme)

Line 235 does a regular zebraw-init (which init-with-theme is a wrapper for) as expected when using zebraw. However, mk-raw calls it again, and this is called in a show rule for every raw block:

shiroa/packages/shiroa/templates.typ

Lines 261 to 274 in fda1a7d

	show raw.where(block: false, tab-size: 114): it => context if shiroa-sys-target() == "paged" {
	it
	} else {
	mk-raw(it, tag: "span", inline: true)
	}
	show raw.where(block: true, tab-size: 114): it => context if shiroa-sys-target() == "paged" {
	rect(width: 100%, inset: (x: 4pt, y: 5pt), radius: 4pt, fill: code-extra-colors.bg, {
	set text(fill: code-extra-colors.fg) if code-extra-colors.fg != none
	set par(justify: false)
	with-raw-theme(theme-style.code-theme, it)
	})
	} else {
	mk-raw(it)
	}

Ultimately, this means that zebraw settings can not be overridden.

Is there a particular reason for doing so? zebraw-init only sets some states, so there should be no benefit from calling it repeatedly.

[Myriad-Dreamin]

the x-problem is to render a block with two themes. to setup the theme we have to init the zebraw repeatedly.

[Myriad-Dreamin]

fwiw, the typst-bulleye's documentation has exactly the problem without zebraw-init per raw block.

This is styled with the light-theme (typst default theme), i.e. failed to apply the theme:

The is styled with tokyo-night, whose color is more contrasted and easy to read:

[ensko]

Hmm... I abandoned trying to override the raw theme for now, but you say I still have problems that should be fixed through that extra zebraw-init? I simply apply code-block-rules of shiroa:0.2.3...

[Myriad-Dreamin]

Hmm... I abandoned trying to override the raw theme for now, but you say I still have problems that should be fixed through that extra zebraw-init? I simply apply code-block-rules of shiroa:0.2.3...

The code-block-rules of shiroa:0.2.3 doesn't contain the fix.

[Myriad-Dreamin]

To be specific, I originally ran zebraw-init repeatedly to apply themes correctly. When developing the startlight theme, I found the typst default theme was still used in the dark mode (thanks laurenz for giving a theme that works almost properly even in the dark mode :( ). I fixed it on the main branch and haven't released a new version.

[ensko]

ooooh, when I run the shiroa command (0.3.1-rc3) it installs a non-universe version of the shiroa and starlight packages, I didn't realize that! So I was looking at main without knowing.

But I also use 0.3.1-rc3 in CI (https://github.com/SillyFreak/typst-bullseye/blob/shiroa/.github/workflows/gh-pages.yml#L31), so should it not also do the same there?

fwiw, I seem to have the light theme code in my local preview too, and there I can confirm that the fix is used.