Make linter happy

Author: Lorenz Kästle

cmd/cloudfront.go

@@ -63,7 +63,7 @@ var cloudfrontCmd = &cobra.Command{
 		for _, distribution := range distributions {
 			var val string
 
-			if *distribution.Distribution.DistributionConfig.Enabled == false {
+			if !*distribution.Distribution.DistributionConfig.Enabled {
 				val = "disabled"
 				rc = 2
 				totalCrit++

cmd/ec2_instances.go

@@ -50,7 +50,7 @@ var ec2InstancesCmd = &cobra.Command{
 			summary += fmt.Sprintf(" %d %s ", count, state)
 			ctr += count
 			if ctr != len(instances.Instances) {
-				summary += fmt.Sprintf("-")
+				summary += "-"
 			}
 		}
 

cmd/s3_buckets.go

@@ -78,7 +78,7 @@ var s3BucketCmd = &cobra.Command{
 		}
 
 		if len(buckets.Buckets) == 0 {
-			check.ExitError(fmt.Errorf("No buckets available"))
+			check.ExitError(fmt.Errorf("no buckets available"))
 		}
 
 		critical, err := internal.ParseThreshold(CriticalBucketSize)
@@ -124,7 +124,7 @@ var s3BucketCmd = &cobra.Command{
 
 			output += objectsOutput.GetBucketOutput(bucketSize, rc)
 
-			if len(buckets.Buckets) > 1 && !(len(buckets.Buckets) == idx+1) {
+			if len(buckets.Buckets) > 1 && (len(buckets.Buckets) != idx+1) {
 				output += "\n"
 			}
 

cmd/s3_objects.go

@@ -89,7 +89,7 @@ var s3ObjectCmd = &cobra.Command{
 		}
 
 		if len(buckets.Buckets) == 0 {
-			check.ExitError(fmt.Errorf("No buckets available"))
+			check.ExitError(fmt.Errorf("no buckets available"))
 		}
 
 		critical, err := internal.ParseThreshold(CriticalObjectSize)

cmd/status.go

@@ -96,7 +96,7 @@ var statusCmd = &cobra.Command{
 		c := &http.Client{}
 
 		if Region == "" && !contains(cliStatusConfig.Service, globalServices) {
-			check.ExitError(fmt.Errorf("Region required for regional services"))
+			check.ExitError(fmt.Errorf("region required for regional services"))
 		}
 
 		// Using + concatenation since the JoinPath will add / inbetween
@@ -115,7 +115,7 @@ var statusCmd = &cobra.Command{
 		}
 
 		if resp.StatusCode != http.StatusOK {
-			check.ExitError(fmt.Errorf("Could not get %s - Error: %d", feedUrl, resp.StatusCode))
+			check.ExitError(fmt.Errorf("could not get %s - Error: %d", feedUrl, resp.StatusCode))
 		}
 
 		defer resp.Body.Close()

internal/s3/client.go

@@ -8,7 +8,7 @@ import (
 	"github.com/aws/aws-sdk-go/service/s3"
 )
 
-var ErrBucketNotFound = errors.New("No such Bucket")
+var ErrBucketNotFound = errors.New("no such Bucket")
 
 type S3Client struct {
 	S3Client *s3.S3