[Feature]: theme light/dark default config option

[SonenPHP]

Describe the feature request

Please bring back the configuration option for "theme" to set default/fallback.
Automatic dark/light mode is fine, but you force the "dark" option as default.

Why? Every user have to set his active theme manual to "light" - otherwise the graph will be dark because it's forced in library/Grafana/Helpers/Util.php

I guess it's a issue because you can not set the default "System Theme Modus" in icingaweb2!?

[martialblog]

Hi,

Icinga Web is using dark mode by default so we decided to have similar behavior.

Problem with the "System Theme Mode" is that the browser then holds the information about which mode is set, thus we don't have it in the PHP code. But we need it for the request to Grafana.

[martialblog]

Thought about it some more. It's tricky, because if we have a "default" option, that would be global and thus override the individual settings a user might have.

We could maybe have a check for "is the user's current theme is different from the default", then use the theme the users wants.

I'll do some experiments when I got some spare time.

[SonenPHP]

Thanks for you thoughts.
Guess i have a problem with Icinga Web using dark mode by default too.

Im using a Theme without dark mode (Classic Icinga), changed it so it supports setting in to light mode manually.
But that wont help much because default dark mode.

Right now my only solution was to change the grafana module source code to default light mode.

Maybe you can provide a better solution in the future :)

[martialblog]

@SonenPHP I implemented something here: #58

Feel free to test it.

[martialblog]

Fixed in https://github.com/NETWAYS/icingaweb2-module-grafana/releases/tag/v3.1.0