-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Description
- Use CloneFactory to deploy XTokens. Check for whitelisted deployed addresses in XStore to prevent issues.
DONE, pending merge approval. - Merge setters into XStore so that one setter can take in a code and modify the appropriate param. Ditto for the NFTX controller.
- Might be easiest to just make vaults public and remove all of the extra get functions. No need for getVault then either.
- Remove xTokenAddress and nftAddress in the Vault struct because you can get them by looking at IXToken and IERC721 and using address(IXToken) etc.
- Better packing of variables in Vault struct to allow for dense representation. (Compiler optimization likely already does this).
- No need for initOwnable to be called in most cases. (Contracts inheriting from Ownable auto-set msg.sender to be owner.)
- RandNonce in XStore seems to do nothing? (And also isn't random?)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels