Skip to content

fix(module:affix): restore width element after hidden state #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(module:affix): restore width element after hidden state #7445

wants to merge 1 commit into from

Conversation

volvachev
Copy link
Contributor

Fixes #7403.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7403

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@volvachev volvachev requested a review from cipchk as a code owner May 18, 2022 17:13
@zorro-bot
Copy link

zorro-bot bot commented May 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #7445 (6690228) into master (8c38518) will decrease coverage by 0.03%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #7445      +/-   ##
==========================================
- Coverage   91.62%   91.59%   -0.04%     
==========================================
  Files         487      491       +4     
  Lines       16043    16113      +70     
  Branches     2477     2486       +9     
==========================================
+ Hits        14700    14759      +59     
- Misses       1029     1039      +10     
- Partials      314      315       +1
Impacted Files Coverage Δ
components/affix/affix.component.ts 88.19% <60.00%> (-1.17%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/table/src/table-data.service.ts 80.32% <0.00%> (-4.92%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-4.35%) ⬇️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-0.71%) ⬇️
components/core/config/config.ts 100.00% <0.00%> (ø)
components/segmented/segmented.component.ts 95.00% <0.00%> (ø)
components/segmented/types.ts 100.00% <0.00%> (ø)
components/core/animation/thumb.ts 100.00% <0.00%> (ø)
components/segmented/segmented.module.ts 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c38518...6690228. Read the comment docs.

cipchk
cipchk requested changes May 19, 2022
View reviewed changes
Copy link
Member

@cipchk cipchk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a reproducible test case for affix.spec.ts?

@volvachev
Copy link
Contributor Author

Can you provide a reproducible test case for affix.spec.ts?

Hi, i don't know how correctly to cover this case by unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipchk cipchk cipchk requested changes

Assignees
No one assigned
Labels
PR: reviewed-changes-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

在响应式布局中使用 nz-anchor 时，锚点的内容不会显示
2 participants
@volvachev @cipchk