Merge pull request #1371 from ckoven/nocomp_seeds

Nocomp seed localization

Author: glemieux

biogeochem/EDPatchDynamicsMod.F90

@@ -17,7 +17,6 @@ module EDPatchDynamicsMod
   use FatesLitterMod       , only : litter_type
   use FatesConstantsMod    , only : n_dbh_bins 
   use FatesLitterMod       , only : adjust_SF_CWD_frac
-  use EDTypesMod           , only : homogenize_seed_pfts
   use EDTypesMod           , only : area
   use FatesConstantsMod    , only : patchfusion_dbhbin_loweredges
   use EDtypesMod           , only : force_patchfuse_min_biomass
@@ -3578,12 +3577,8 @@ subroutine DistributeSeeds(currentSite,seed_mass,el,pft)
       do while(associated(currentPatch)) 
           litt => currentPatch%litter(el)
 
-          if(homogenize_seed_pfts) then
-              litt%seed(:) = litt%seed(:) + seed_mass/(area_site*real(numpft,r8))
-          else
-              litt%seed(pft) = litt%seed(pft) + seed_mass/area_site
-          end if
-          
+          litt%seed(pft) = litt%seed(pft) + seed_mass/area_site
+
           currentPatch => currentPatch%younger
       end do
 

biogeochem/EDPhysiologyMod.F90

@@ -2054,7 +2054,6 @@ subroutine SeedUpdate( currentSite )
 
     ! !USES:
     use EDTypesMod, only : area
-    use EDTypesMod, only : homogenize_seed_pfts
     use FatesInterfaceTypesMod, only : hlm_seeddisp_cadence
     use FatesInterfaceTypesMod, only : fates_dispersal_cadence_none
     !
@@ -2078,6 +2077,11 @@ subroutine SeedUpdate( currentSite )
     integer  :: el                     ! loop counter for litter element types
     integer  :: element_id             ! element id consistent with parteh/PRTGenericMod.F90
 
+    logical, parameter  :: nocomp_seed_localization  = .true.  ! if nocomp is on, only send a given PFT's seeds to patches of that nocomp PFT
+    real(r8) :: nocomp_seed_scaling    ! scalar to handle case for nocomp_seed_localization
+    real(r8) :: seed_supply            ! external seed rain scalar to handle case for nocomp_seed_localization
+    real(r8) :: nocomp_patch_areas(0:numpft) ! vector of the total patch areas for each nocomp PFT
+
     ! If the dispersal kernel is not turned on, keep the dispersal fraction at zero
     site_disp_frac(:) = 0._r8
     if (hlm_seeddisp_cadence .ne. fates_dispersal_cadence_none) then
@@ -2091,6 +2095,19 @@ subroutine SeedUpdate( currentSite )
 
        site_mass => currentSite%mass_balance(el)
 
+       ! If we are in nocomp configuration and we are restricting each PFT's seeds to all fall
+       ! only on patches that allow that PFT to grow, then we need to add up all the patch areas
+       ! for each nocomp PFT to normalize the seed fluxes with later.
+       if (nocomp_seed_localization .and. hlm_use_nocomp .eq. itrue ) then
+          nocomp_patch_areas(0:numpft) = 0._r8
+          currentPatch => currentSite%oldest_patch
+          nocomp_patch_loop: do while (associated(currentPatch))
+             nocomp_patch_areas(currentPatch%nocomp_pft_label) = nocomp_patch_areas(currentPatch%nocomp_pft_label) &
+                  + currentPatch%area
+             currentPatch => currentPatch%younger
+          end do nocomp_patch_loop
+       endif
+
        ! Loop over all patches and sum up the seed input for each PFT
        currentPatch => currentSite%oldest_patch
        seed_rain_loop: do while (associated(currentPatch))
@@ -2132,13 +2149,6 @@ subroutine SeedUpdate( currentSite )
           currentPatch => currentPatch%younger
        enddo seed_rain_loop
 
-       ! We can choose to homogenize seeds. This is simple, we just
-       ! add up all the seed from each pft at the site level, and then
-       ! equally distribute to the PFT pools
-       if ( homogenize_seed_pfts ) then
-          site_seed_rain(1:numpft) = sum(site_seed_rain(:))/real(numpft,r8)
-       end if
-
        ! Loop over all patches again and disperse the mixed seeds into the input flux
        ! arrays
        ! Loop over all patches and sum up the seed input for each PFT
@@ -2150,9 +2160,25 @@ subroutine SeedUpdate( currentSite )
 
              if(currentSite%use_this_pft(pft).eq.itrue)then
 
+                ! special case: do we want to restrict each PFT's seeds to only go to patches with that nocomp PFT label?
+                ! If so, then use a normalization factor that is one over the nocomp patch fraction for all patches of
+                ! that PFT's nocomp label, and zero for all other patches.  If we don't do this, then just set scalar to one.
+                ! Similarly, only add external seed rain to a given PFT's nocomp patches
+                nocomp_seed_scaling = 1._r8
+                seed_supply = EDPftvarcon_inst%seed_suppl(pft)
+                if (nocomp_seed_localization .and. hlm_use_nocomp .eq. itrue ) then
+                   if (currentPatch%nocomp_pft_label .eq. pft) then
+                      nocomp_seed_scaling = AREA/nocomp_patch_areas(pft)
+                   else
+                      nocomp_seed_scaling = 0._r8
+                      seed_supply = 0._r8
+                   endif
+                endif
+
                 ! Seed input from local sources (within site).  Note that a fraction of the
                 ! internal seed rain is sent out to neighboring gridcells.
-                litt%seed_in_local(pft) = litt%seed_in_local(pft) + site_seed_rain(pft)*(1.0_r8-site_disp_frac(pft))/area ![kg/m2/day]
+                litt%seed_in_local(pft) = litt%seed_in_local(pft) + nocomp_seed_scaling * &
+                     (1.0_r8-site_disp_frac(pft)) * (site_seed_rain(pft)/area) ! site_seed_rain conversion from [kg/site/day -> kg/m2/day]
 
                 ! If we are using the Tree Recruitment Scheme (TRS) with or w/o seedling dynamics
                 if ( any(hlm_regeneration_model == [TRS_regeneration, TRS_no_seedling_dyn]) .and. &
@@ -2184,7 +2210,7 @@ subroutine SeedUpdate( currentSite )
 
                 ! Seed input from external sources (user param seed rain, or dispersal model)
                 ! Include both prescribed seed_suppl and seed_in dispersed from neighbouring gridcells
-                seed_in_external = seed_stoich*(currentSite%seed_in(pft)/area + EDPftvarcon_inst%seed_suppl(pft)*years_per_day) ![kg/m2/day]
+                seed_in_external = seed_stoich * (seed_supply*years_per_day + currentSite%seed_in(pft)/area  ![kg/m2/day]
                 litt%seed_in_extern(pft) = litt%seed_in_extern(pft) + seed_in_external
 
                 ! Seeds entering externally [kg/site/day]

main/EDTypesMod.F90

@@ -129,7 +129,6 @@ module EDTypesMod
                                                                           ! number densities of cohorts to prevent FPEs
 
   ! special mode to cause PFTs to create seed mass of all currently-existing PFTs
-  logical, parameter, public :: homogenize_seed_pfts  = .false.
   character(len=*), parameter, private :: sourcefile = __FILE__
 
   !************************************