Inconsistencies in TwoStreamMLPEmod

[mvdebolskiy]

Public parameters nearzero, fates_unset_r8,fates_unset_int are defined here (f.e.):

fates/main/FatesConstantsMod.F90

Line 204 in 75a465c

real(fates_r8), parameter, public :: nearzero = 1.0e-30_fates_r8

While a private nearzero and unset_r8, unset_int are defined in TwoStreamMLPEMod and assigned different values:

fates/radiation/TwoStreamMLPEMod.F90

Line 34 in 75a465c

real(r8),parameter :: nearzero = 1.e-20_r8

@rgknox @glemieux is the reason for this unit testing (there is nothing in the comments)?

[rgknox]

yes, the reason is unit testing. But I can write a wrapper to run some "getter" calls to assign these. Thanks for bringing this up @mvdebolskiy

[rgknox]

@mvdebolskiy , do you believe this is causing problems, or is this just a question about consistency and best practices?

[mvdebolskiy]

@rgknox I don't think it is causing the problems, since gnu with -Wall -Wextra and -Werror usually fails build if there are variables with the same name as in global scope. It's just that the values are different is triggering me.