Skip to content

Commit 49e79be

Browse files
committed
Merge PR OCA#1113 into 18.0
Signed-off-by pedrobaeza
2 parents f7bad0f + f746c2d commit 49e79be

File tree

4 files changed

+19
-15
lines changed

4 files changed

+19
-15
lines changed

website_cookiefirst/README.rst

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,10 @@ To configure this module, you need to:
4444

4545
1. Go to **Website > Configuration > Settings**
4646
2. Search 'Cookiefirst' option.
47-
3. Fill in your 'Cookiefirst ID' (e.g.
48-
'00000000-0000-0000-0000-000000000000').
49-
4. Click on "Save" button.
47+
3. Enable Use Cookiefirst checkbox
48+
4. Enter your Cookiefirst **API Key** into **Cookiefirst ID** field
49+
(e.g. '00000000-0000-0000-0000-000000000000').
50+
5. Click on "Save" button.
5051

5152
⚠️ **Please note: if another cookie consent solution is installed (e.g.
5253
Cookiebot), the execution of the Cookiefirst script will be prevented.
@@ -74,13 +75,14 @@ Authors
7475
Contributors
7576
------------
7677

77-
- `Studio73 <https://www.studio73.es>`__:
78+
- `Studio73 <https://www.studio73.es>`__:
7879

79-
- Ioan Galan <ioan@studio73.es>
80+
- Ioan Galan <ioan@studio73.es>
8081

81-
- `NICO SOLUTIONS - ENGINEERING & IT <https://www.nico-solutions.de>`__:
82+
- `NICO SOLUTIONS - ENGINEERING &
83+
IT <https://www.nico-solutions.de>`__:
8284

83-
- Nils Coenen nils.coenen@nico-solutions.de
85+
- Nils Coenen nils.coenen@nico-solutions.de
8486

8587
Maintainers
8688
-----------

website_cookiefirst/readme/CONFIGURE.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ To configure this module, you need to:
22

33
1. Go to **Website \> Configuration \> Settings**
44
2. Search 'Cookiefirst' option.
5-
3. Fill in your 'Cookiefirst ID' (e.g.
5+
3. Enable Use Cookiefirst checkbox
6+
4. Enter your Cookiefirst **API Key** into **Cookiefirst ID** field (e.g.
67
'00000000-0000-0000-0000-000000000000').
7-
4. Click on "Save" button.
8+
5. Click on "Save" button.
89

910
⚠️ **Please note: if another cookie consent solution is
1011
installed (e.g. Cookiebot), the execution of the Cookiefirst

website_cookiefirst/static/description/index.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,8 +392,9 @@ <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
392392
<ol class="arabic simple">
393393
<li>Go to <strong>Website &gt; Configuration &gt; Settings</strong></li>
394394
<li>Search ‘Cookiefirst’ option.</li>
395-
<li>Fill in your ‘Cookiefirst ID’ (e.g.
396-
‘00000000-0000-0000-0000-000000000000’).</li>
395+
<li>Enable Use Cookiefirst checkbox</li>
396+
<li>Enter your Cookiefirst <strong>API Key</strong> into <strong>Cookiefirst ID</strong> field
397+
(e.g. ‘00000000-0000-0000-0000-000000000000’).</li>
397398
<li>Click on “Save” button.</li>
398399
</ol>
399400
<p>⚠️ <strong>Please note: if another cookie consent solution is installed (e.g.
@@ -424,7 +425,8 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
424425
<li>Ioan Galan &lt;<a class="reference external" href="mailto:ioan&#64;studio73.es">ioan&#64;studio73.es</a>&gt;</li>
425426
</ul>
426427
</li>
427-
<li><a class="reference external" href="https://www.nico-solutions.de">NICO SOLUTIONS - ENGINEERING &amp; IT</a>:<ul>
428+
<li><a class="reference external" href="https://www.nico-solutions.de">NICO SOLUTIONS - ENGINEERING &amp;
429+
IT</a>:<ul>
428430
<li>Nils Coenen <a class="reference external" href="mailto:nils.coenen&#64;nico-solutions.de">nils.coenen&#64;nico-solutions.de</a></li>
429431
</ul>
430432
</li>

website_cookiefirst/views/website_template.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@
1717
<attribute name="data-cookiefirst-category">performance</attribute>
1818
</xpath>
1919
<xpath expr="//div[@id='wrapwrap']" position="after">
20-
<t t-if="website.cookiefirst_identifier">
20+
<t t-if="website.cookiefirst_identifier and website.domain">
2121
<script
22-
src="https://consent.cookiefirst.com/banner.js"
23-
t-att-data-cookiefirst-key="website.cookiefirst_identifier"
22+
t-attf-src="https://consent.cookiefirst.com/sites/{{ (website.domain or '').replace('http://', '').replace('https://', '').replace('www.', '') }}-{{ website.cookiefirst_identifier }}/consent.js"
2423
/>
2524
</t>
2625
</xpath>

0 commit comments

Comments
 (0)