- Fix analyzer warning in mesh_new_client.

wcawijngaards · wcawijngaards · commit c0741ccc68bd · 2026-05-27T16:03:15.000+02:00
diff --git a/doc/Changelog b/doc/Changelog
@@ -30,6 +30,7 @@
 	- Fix that validator caps number of ANY RRsets it can
 	  validate, and the wait timer is shortened. Thanks to Qifan
 	  Zhang, Palo Alto Networks, for the report.
+	- Fix analyzer warning in mesh_new_client.
 
 26 May 2026: Wouter
 	- Fix for mesh new client and mesh new callback to rollback the
diff --git a/services/mesh.c b/services/mesh.c
@@ -610,7 +610,8 @@ void mesh_new_client(struct mesh_area* mesh, struct query_info* qinfo,
 		}
 	}
 #endif
-	added_reply_without_accounting = 0;
+	/* Since the acccounting now happens,
+	 * added_reply_without_accounting = 0;   but that is not used. */
 	infra_wait_limit_inc(mesh->env->infra_cache, rep, *mesh->env->now,
 		mesh->env->cfg);
 	/* update statistics */

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,8 @@ void mesh_new_client(struct mesh_area* mesh, struct query_info* qinfo,`
`610`	`610`	`}`
`611`	`611`	`}`
`612`	`612`	`#endif`
`613`		`- added_reply_without_accounting = 0;`
	`613`	`+ /* Since the acccounting now happens,`
	`614`	`+ * added_reply_without_accounting = 0; but that is not used. */`
`614`	`615`	`infra_wait_limit_inc(mesh->env->infra_cache, rep, *mesh->env->now,`
`615`	`616`	`mesh->env->cfg);`
`616`	`617`	`/* update statistics */`