Skip to content

Commit 0510246

Browse files
authored
Added a testing case that should resolve to BOG (#429)
* Added a testing case that should resolve to BOG * 22 * 3 3 3 * Removed the test data to leave only the workflow changes. Reviewdog indeed made suggestions in each run. But it was set to fail upon any differece due to a misunderstanding of what the fail_level meant. Now, we set fail_level: none # post suggestions without failing the job Also made the output of the python script visible for debugging. The changes need to be merged into main to become effective.
1 parent 8bd0250 commit 0510246

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/AutocompleteMetadata.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,19 @@ jobs:
5454
CHANGED_FILES: ${{ steps.files.outputs.changed_files }}
5555
CAS_API_KEY: ${{ secrets.CAS_API_KEY }}
5656
run: |
57-
printf '%s\n' "$CHANGED_FILES" | while IFS= read -r f; do
58-
[ -n "$f" ] && python "$RUNNER_TEMP/Databank/developer/autocomplete_metadata.py" "$f"
59-
done
57+
set -euo pipefail
58+
while IFS= read -r f; do
59+
[ -n "$f" ] || continue
60+
echo "::group::autocomplete_metadata.py $f"
61+
python "$RUNNER_TEMP/Databank/developer/autocomplete_metadata.py" "$f"
62+
echo "::endgroup::"
63+
done <<< "$CHANGED_FILES"
6064
6165
- name: Suggest changes on PR
6266
if: steps.files.outputs.changed_files != ''
6367
uses: reviewdog/action-suggester@v1
6468
with:
6569
tool_name: addmetadata
6670
github_token: ${{ secrets.GITHUB_TOKEN }}
67-
fail_level: any # surface errors instead of exiting 0
71+
fail_level: none # post suggestions without failing the job
6872
reviewdog_flags: -tee # echo reviewdog's stdout/stderr to the log

0 commit comments

Comments
 (0)