Skip to content

Commit 9beb4b9

Browse files
committed
Fix analyze.py to adopt changes in nmrpca code
1 parent ccad4d5 commit 9beb4b9

2 files changed

Lines changed: 2 additions & 19 deletions

File tree

src/fairmd/lipids/analib/analyze_nmrpca.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,12 @@
4646

4747
import MDAnalysis as mda
4848
import numpy as np
49-
from deprecated import deprecated
5049
from MDAnalysis.analysis.base import AnalysisFromFunction
5150
from scipy import signal
5251

5352
from fairmd.lipids import FMDL_SIMU_PATH
5453
from fairmd.lipids.api import lipids_set
5554
from fairmd.lipids.core import System
56-
from fairmd.lipids.databankio import download_resource_from_uri, resolve_file_url
5755
from fairmd.lipids.molecules import Lipid
5856
from fairmd.lipids.schema_validation.engines import get_struc_top_traj_fnames
5957

@@ -234,7 +232,7 @@ def verify_lipid(lipid: Lipid) -> bool:
234232
has_sn1 = True
235233
if v["FRAGMENT"] in __tailsn2_vars:
236234
has_sn2 = True
237-
return (has_sn1 and has_sn2)
235+
return has_sn1 and has_sn2
238236

239237
def concatenate_traj(self) -> None:
240238
"""Create Concatenator and corresponding concatenated trajectories.

src/fairmd/lipids/analyze.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -67,33 +67,18 @@ def computeNMRPCA( # noqa: N802 (API)
6767
# TODO: 2test| parser = Parser(FMDL_SIMU_PATH, readme, eq_time_fname, testTraj)
6868
try:
6969
parser = nmrpca.Parser(system, "eq_times.json")
70-
# Check trajectory
7170
print(parser._path)
72-
vpcode = parser.validate_path()
73-
print("ValidatePath code: ", vpcode)
7471
except Exception:
7572
logger.exception("Error initializing NMRPCA parser.")
7673
return RCODE_ERROR
7774

78-
if vpcode > 0:
79-
logger.error("Some errors in analyze_nmrpca.py::Parser constructor.")
80-
return RCODE_ERROR
81-
8275
if (
83-
(vpcode < 0 and not recompute)
76+
(os.path.isfile(os.path.join(FMDL_SIMU_PATH, system["path"], "eq_times.json")) and not recompute)
8477
or ("WARNINGS" in system and system["WARNINGS"] is not None and "AMBIGUOUS_ATOMNAMES" in system["WARNINGS"])
8578
or ("WARNINGS" in system and system["WARNINGS"] is not None and "SKIP_EQTIMES" in system["WARNINGS"])
8679
):
8780
return RCODE_SKIPPED
8881

89-
# Check if TPR is defined and non-null or ""
90-
try:
91-
__ = system["TPR"][0][0]
92-
_ = __[0]
93-
except (KeyError, TypeError):
94-
logger.exception("TPR is required for NMRPCA analysis (%d})!", system["ID"])
95-
return RCODE_ERROR
96-
9782
try:
9883
# Download md data
9984
uc = UniverseConstructor(system)

0 commit comments

Comments
 (0)