fix(get_functions): handle NULL/Na data in functions and unit tests

Author: andybeet

R/get_species_itis.R

@@ -27,7 +27,7 @@
 get_species_itis <- function(itis = NULL, stock = NULL) {
   # Error check for metric names
   if (is.null(itis) & is.null(stock)) {
-    stop(
+    return(
       "If you do not know the ITIS code then please enter a value for the
     `stock` argument. A character string of any part of the stock name.
          eg stock = \"Albacore\", stock = \"Cape Cod\""

R/get_species_stock_data.R

@@ -18,6 +18,9 @@
 get_species_stock_data <- function(itis = NULL, stock = NULL) {
   # extract the stock ids since that is what is needed for the API
   meta <- get_species_itis(itis = itis, stock = stock)
+  if (is.character(meta)) {
+    return(meta)
+  }
   user_stockids <- meta$StockID
 
   # Start pull query

tests/testthat/test-get_species_itis.R

@@ -47,5 +47,6 @@ test_that("get_species_itis with specific itis", {
 
 # test null both argument
 test_that("get_species_itis with null itis and stock", {
-  expect_error(get_species_itis())
+  res <- get_species_itis()
+  expect_true(is.character(res))
 })

tests/testthat/test-get_species_stock_data.R

@@ -43,5 +43,6 @@ test_that("get_species_stock_data with itis as numeric, stock is null", {
 
 # test null both argument
 test_that("get_species_stock_data with null itis and stock", {
-  expect_error(get_species_stock_data())
+  res <- get_species_stock_data()
+  expect_true(is.character(res))
 })