ww3_outp compilation issue

[JessicaMeixner-NOAA]

Describe the bug
Originally reported via email from @ukmo-kitstokes the compilation issue is:

It seems like a relatively trivial fix to change the incorrect ACCESS=’APPEND’ commands on lines 939 and 942 as these are incorrect syntax

This appears to be associated with PR #1365

[JessicaMeixner-NOAA]

@AliS-Noaa - Can you take a look at this possible bug fix that possibly crept in with PR #1365? Not sure if we'll be able to recreate the error message or not but maybe we can make a PR with a fix based on the info we have here and ask @ukmo-kitstokes to test if we can't reproduce on our end?

[JessicaMeixner-NOAA]

Tagging @ukmo-rwdavies

[AliS-Noaa]

I see no issue with intel compiler. I believe the cray fortran compiler does not like this ACCESS argument. I have revised the code snip and created a new branch for testing with the cray compiler: https://github.com/AliS-Noaa/WW3/tree/outp-access
@ukmo-kitstokes @ukmo-rwdavies I would appreciate it if you can test this branch.

[ukmo-kitstokes]

Thanks Ali, I appreciate you looking at that so quickly. Rich is testing this out now and we'll get back to you.

[ukmo-rwdavies]

@AliS-Noaa Thanks for your prompt response and for making this change. (Unfortunately, with a recent upgrade to a new HPC, we no longer have access to Intel compilers.) With your update to 'ww3_outp.F90', compilation with our Cray Fortran compilers is now successful. We're currently working to set-up a test suite of our operational waves model. Hopefully, once this is done, and we have some output, I'll be able to provide further confirmation that everything works. Thanks again.

[JessicaMeixner-NOAA]

@ukmo-rwdavies - Please feel free to post issues here as you run into them. We don't have a cray compiler to reproduce the errors you are seeing but hopefully we can work together to solve any issues that you might encounter.

Let us know when you're ready for a PR for the ww3_outp changes.

[ukmo-rwdavies]

@JessicaMeixner-NOAA - Thanks Jessica.

[ukmo-kitstokes]

Hi Jessica, can you just confirm what the process is to close this off please? You mention a PR for this - will that come from our side or your side? I presume you mean you want us to do a test at our end as part of a PR, is that right?

[JessicaMeixner-NOAA]

@AliS-Noaa has a branch and can make a PR from that branch. We're just waiting to have further confirmation from you that this is working on your end since we cannot replicate the issues you are seeing.

[AliS-Noaa]

I am running the regression tests and I will make the pull request soon.

[ukmo-kitstokes]

Thanks both, the code now compiles and we're about to run a couple of test simulations. We will report back on that.

[AliS-Noaa]

@JessicaMeixner-NOAA I already ran the reg tests and all looks good with the changes for cray compiler, should I wait for the pull request until we get confirmation?

[JessicaMeixner-NOAA]

Yes, go ahead and make the PR and then we'll wait for other's testing before merging.