Skip to content

Unused variables #532

Description

@manfredsc

wgrib2/src/cubed_sphere2ll.c: In function 'cubed_sphere2ll':
wgrib2/src/cubed_sphere2ll.c:32:37: warning: variable 'tile_end' set but not used [-Wunused-but-set-variable=]
32 | int gds_tile, tile, tile_start, tile_end;
| ^~~~~~~~
wgrib2/src/cubed_sphere2ll.c:32:25: warning: variable 'tile_start' set but not used [-Wunused-but-set-variable=]
32 | int gds_tile, tile, tile_start, tile_end;
| ^~~~~~~~~~
wgrib2/src/cubed_sphere2ll.c: At top level:
wgrib2/src/cubed_sphere2ll.c:222:5: warning: no previous prototype for 'cubed_spherell2xy' [-Wmissing-prototypes]
222 | int cubed_spherell2xy(unsigned char **sec, int n, double *lon, double *lat, double *xx, double *yy, int *face) {
| ^~~~~~~~~~~~~~~~~
wgrib2/src/cubed_sphere2ll.c: In function 'cubed_spherell2xy':
wgrib2/src/cubed_sphere2ll.c:226:29: warning: unused variable 'yprime' [-Wunused-variable]
226 | double x, y, z, xprime, yprime, zprime;
| ^~~~~~
wgrib2/src/cubed_sphere2ll.c:226:15: warning: variable 'y' set but not used [-Wunused-but-set-variable=]
226 | double x, y, z, xprime, yprime, zprime;
| ^
wgrib2/src/cubed_sphere2ll.c:224:55: warning: variable 'cos_a' set but not used [-Wunused-but-set-variable=]
224 | double sp_lat, sp_lon, angle_rot, a, c, r, sin_a, cos_a;
| ^~~~~
wgrib2/src/cubed_sphere2ll.c:224:48: warning: variable 'sin_a' set but not used [-Wunused-but-set-variable=]
224 | double sp_lat, sp_lon, angle_rot, a, c, r, sin_a, cos_a;
| ^~~~~
wgrib2/src/cubed_sphere2ll.c:224:45: warning: variable 'r' set but not used [-Wunused-but-set-variable=]
224 | double sp_lat, sp_lon, angle_rot, a, c, r, sin_a, cos_a;
| ^
wgrib2/src/cubed_sphere2ll.c:223:21: warning: unused variable 'j' [-Wunused-variable]
223 | unsigned int i, j;
| ^

Looking closer, the function cubed_spherell2xy is unused, unfinished, and has no prototype.

Handled in #531.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions