fix(mass_balance): use conditinonal macro for nodiscard attribute (c++17)

Author: hellkite500

include/utilities/bmi/mass_balance.hpp

@@ -104,7 +104,7 @@ namespace models{ namespace bmi{ namespace protocols{
          * @return expected<void, ProtocolError> May contain a ProtocolError if
          *         the protocol is not supported by the model.
          */
-        [[nodiscard]] auto check_support(const ModelPtr& model) -> expected<void, ProtocolError> override;
+        nsel_NODISCARD auto check_support(const ModelPtr& model) -> expected<void, ProtocolError> override;
 
         /**
          * @brief Check the model for support and initialize the mass balance protocol from the given properties.

include/utilities/bmi/protocol.hpp

@@ -143,7 +143,7 @@ class NgenBmiProtocol{
      *         the protocol fails for any reason.  Errors of ProtocolError::PROTOCOL_WARNING
      *         severity should be logged as warnings, but not cause the simulation to fail.
      */
-    [[nodiscard]] virtual auto run(const ModelPtr& model, const Context& ctx) const -> expected<void, ProtocolError> = 0;
+    nsel_NODISCARD virtual auto run(const ModelPtr& model, const Context& ctx) const -> expected<void, ProtocolError> = 0;
 
     /**
      * @brief Check if the BMI protocol is supported by the model
@@ -158,7 +158,7 @@ class NgenBmiProtocol{
      * @return expected<void, ProtocolError> May contain a ProtocolError if
      *         the protocol is not supported by the model.
      */
-    [[nodiscard]] virtual expected<void, ProtocolError> check_support(const ModelPtr& model) = 0;
+    nsel_NODISCARD virtual expected<void, ProtocolError> check_support(const ModelPtr& model) = 0;
 
     /**
      * @brief Initialize the BMI protocol from a set of key/value properties