You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed here, there are comments in Layer.cpp noting a possible issue with accumulated catchment outflow values, and whether this data is in the appropriate units. If data is being gather or used in the wrong units, this needs to be confirmed and corrected. Regardless, this comment then needs to be updated to avoid confusion.
Note
The involved code was already present, albeit unreachable, in master prior to #974. That PR technically will make or has made the code reachable, but at this time, it is very unlikely to be encountered in practice because it also requires the BMI-type integration with t-route. That is not the typical way t-route is used with ngen. So the priority of this is not urgent, but it still needs to be addressed.
As discussed here, there are comments in Layer.cpp noting a possible issue with accumulated catchment outflow values, and whether this data is in the appropriate units. If data is being gather or used in the wrong units, this needs to be confirmed and corrected. Regardless, this comment then needs to be updated to avoid confusion.
Note
The involved code was already present, albeit unreachable, in
masterprior to #974. That PR technically will make or has made the code reachable, but at this time, it is very unlikely to be encountered in practice because it also requires the BMI-type integration with t-route. That is not the typical way t-route is used with ngen. So the priority of this is not urgent, but it still needs to be addressed.