Skip to content

Improve HY_PointHydroNexus::get_downstream_flow and potentially other code related to PR 931 #995

Description

@robertbartel

See #931 and this comment for a little more context.

That was a fairly subtle bug, caused by a flaw which remained dormant until another, seemingly appropriate and safe change was made. That suggests to me more fundamental problems that eventually need more attention.

Some ideas to focus on include, but are not limited to:

  • refactoring and improving HY_PointHydroNexus::get_downstream_flow, both for code style/readability and technical design
  • ensuring robust automated testing around all the various scenarios, especially those that slipped through previously
  • improving the design with respect to how flow and contributing catchments are related (two things that seem pretty closely related in the real world)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions