Skip to content

[3pt] Upgrade version number system #235

Open
@RobHanna-NOAA

Description

@RobHanna-NOAA

We have a few places that have output files that use a column named "version" which is intended to be the ras2fim code version from the change log. We have a helper function for it in shared functions called get_changelog_version. Currently, the value always being returned instead of the actual version number is the phrase "docs/CHANGELOG.md". This is happening because the value being passed in was not a full path, only this partial path.

There are a couple of way to fix this:

  1. Continue to let calling functions pass in the path to get_changelog_version but ensure they are sending in a full path. If we do this, we need to add a test inside the function to validate the full path value coming in exists. AND.. fix all calling functions for the full path

OR

  1. (preferred). Make get_changelog_versoin figure out it's own dynamic pathing to where the CHANGELOG.md is at so it does not need to be passed in.

This change is need for V2 only and shows up in some rating curve output files.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions